[css-masking-1] Interpolation of mask-border properties #529
Comments
|
The CSS Working Group just discussed
The full IRC log of that discussion<lea> 2nd Straw poll posted! https://github.com/w3c/csswg-drafts/issues/7542#issuecomment-1747805436<fantasai> ntim: The properties are marked as discretely animatable, but that's inconsistent with border-image which is animatable by computed style <fantasai> ntim: I know mask-border was based off border-image, so I was wondering why the inconsistency? <TabAtkins> +1 to matching border-image <TabAtkins> fantasai: I suspect (haven't checked) is that animatable lines weren't added in the source, and Bikeshed defaults them to discrete <TabAtkins> fantasai: But yes it makes sense to make them consistent <TabAtkins> (I could just make it an error at this point; that didn't make sense before.) <fantasai> astearns: Proposed to change mask border properties to match border-image <fantasai> RESOLVED: mask-border properties will match border-image wrt animatability |
nt1m
added a commit
to nt1m/WebKit
that referenced
this issue
Jul 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=277313 Reviewed by NOBODY (OOPS!). Spec resolution: w3c/fxtf-drafts#529 (comment) Spec PR: w3c/fxtf-drafts#565 mask-border-* properties should match border-image-* properties in terms of animation. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation.html: Added. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setMaskBorderSource): (WebCore::RenderStyle::setMaskBorderSliceFill): (WebCore::RenderStyle::setMaskBorderSlices): (WebCore::RenderStyle::setMaskBorderWidth): (WebCore::RenderStyle::setMaskBorderOutset): (WebCore::RenderStyle::setMaskBorderHorizontalRule): (WebCore::RenderStyle::setMaskBorderVerticalRule): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::maskBorderHorizontalRule const): (WebCore::RenderStyle::maskBorderOutset const): (WebCore::RenderStyle::maskBorderSlices const): (WebCore::RenderStyle::maskBorderVerticalRule const): (WebCore::RenderStyle::maskBorderWidth const): * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setMaskBorder): (WebCore::RenderStyle::setMaskBorderSource): Deleted.
nt1m
added a commit
to nt1m/WebKit
that referenced
this issue
Jul 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=277313 rdar://132783274 Reviewed by NOBODY (OOPS!). Spec resolution: w3c/fxtf-drafts#529 (comment) Spec PR: w3c/fxtf-drafts#565 mask-border-* properties should match border-image-* properties in terms of animation. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation.html: Added. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setMaskBorderSource): (WebCore::RenderStyle::setMaskBorderSliceFill): (WebCore::RenderStyle::setMaskBorderSlices): (WebCore::RenderStyle::setMaskBorderWidth): (WebCore::RenderStyle::setMaskBorderOutset): (WebCore::RenderStyle::setMaskBorderHorizontalRule): (WebCore::RenderStyle::setMaskBorderVerticalRule): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::maskBorderHorizontalRule const): (WebCore::RenderStyle::maskBorderOutset const): (WebCore::RenderStyle::maskBorderSlices const): (WebCore::RenderStyle::maskBorderVerticalRule const): (WebCore::RenderStyle::maskBorderWidth const): * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setMaskBorder): (WebCore::RenderStyle::setMaskBorderSource): Deleted.
nt1m
added a commit
to nt1m/WebKit
that referenced
this issue
Jul 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=277313 rdar://132783274 Reviewed by NOBODY (OOPS!). Spec resolution: w3c/fxtf-drafts#529 (comment) Spec PR: w3c/fxtf-drafts#565 mask-border-* properties should match border-image-* properties in terms of animation. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation.html: Added. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const): (WebCore::RenderStyle::setMaskBorderSource): (WebCore::RenderStyle::setMaskBorderSliceFill): (WebCore::RenderStyle::setMaskBorderSlices): (WebCore::RenderStyle::setMaskBorderWidth): (WebCore::RenderStyle::setMaskBorderOutset): (WebCore::RenderStyle::setMaskBorderHorizontalRule): (WebCore::RenderStyle::setMaskBorderVerticalRule): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::maskBorderHorizontalRule const): (WebCore::RenderStyle::maskBorderOutset const): (WebCore::RenderStyle::maskBorderSlices const): (WebCore::RenderStyle::maskBorderVerticalRule const): (WebCore::RenderStyle::maskBorderWidth const): * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setMaskBorder): (WebCore::RenderStyle::setMaskBorderSource): Deleted.
nt1m
added a commit
to nt1m/WebKit
that referenced
this issue
Jul 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=277313 rdar://132783274 Reviewed by NOBODY (OOPS!). Spec resolution: w3c/fxtf-drafts#529 (comment) Spec PR: w3c/fxtf-drafts#565 mask-border-* properties should match border-image-* properties in terms of animation. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation.html: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const): (WebCore::RenderStyle::setMaskBorderSource): (WebCore::RenderStyle::setMaskBorderSliceFill): (WebCore::RenderStyle::setMaskBorderSlices): (WebCore::RenderStyle::setMaskBorderWidth): (WebCore::RenderStyle::setMaskBorderOutset): (WebCore::RenderStyle::setMaskBorderHorizontalRule): (WebCore::RenderStyle::setMaskBorderVerticalRule): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::maskBorderHorizontalRule const): (WebCore::RenderStyle::maskBorderOutset const): (WebCore::RenderStyle::maskBorderSlices const): (WebCore::RenderStyle::maskBorderVerticalRule const): (WebCore::RenderStyle::maskBorderWidth const): * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setMaskBorder): (WebCore::RenderStyle::setMaskBorderSource): Deleted.
webkit-commit-queue
pushed a commit
to nt1m/WebKit
that referenced
this issue
Jul 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=277313 rdar://132783274 Reviewed by Darin Adler. Spec resolution: w3c/fxtf-drafts#529 (comment) Spec PR: w3c/fxtf-drafts#565 mask-border-* properties should match border-image-* properties in terms of animation. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation.html: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const): (WebCore::RenderStyle::setMaskBorderSource): (WebCore::RenderStyle::setMaskBorderSliceFill): (WebCore::RenderStyle::setMaskBorderSlices): (WebCore::RenderStyle::setMaskBorderWidth): (WebCore::RenderStyle::setMaskBorderOutset): (WebCore::RenderStyle::setMaskBorderHorizontalRule): (WebCore::RenderStyle::setMaskBorderVerticalRule): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::maskBorderHorizontalRule const): (WebCore::RenderStyle::maskBorderOutset const): (WebCore::RenderStyle::maskBorderSlices const): (WebCore::RenderStyle::maskBorderVerticalRule const): (WebCore::RenderStyle::maskBorderWidth const): * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setMaskBorder): (WebCore::RenderStyle::setMaskBorderSource): Deleted. Canonical link: https://commits.webkit.org/281569@main
davidtranhq
pushed a commit
to davidtranhq/WebKit
that referenced
this issue
Jul 30, 2024
https://bugs.webkit.org/show_bug.cgi?id=277313 rdar://132783274 Reviewed by Darin Adler. Spec resolution: w3c/fxtf-drafts#529 (comment) Spec PR: w3c/fxtf-drafts#565 mask-border-* properties should match border-image-* properties in terms of animation. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation.html: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added. * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const): (WebCore::RenderStyle::setMaskBorderSource): (WebCore::RenderStyle::setMaskBorderSliceFill): (WebCore::RenderStyle::setMaskBorderSlices): (WebCore::RenderStyle::setMaskBorderWidth): (WebCore::RenderStyle::setMaskBorderOutset): (WebCore::RenderStyle::setMaskBorderHorizontalRule): (WebCore::RenderStyle::setMaskBorderVerticalRule): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::maskBorderHorizontalRule const): (WebCore::RenderStyle::maskBorderOutset const): (WebCore::RenderStyle::maskBorderSlices const): (WebCore::RenderStyle::maskBorderVerticalRule const): (WebCore::RenderStyle::maskBorderWidth const): * Source/WebCore/rendering/style/RenderStyleSetters.h: (WebCore::RenderStyle::setMaskBorder): (WebCore::RenderStyle::setMaskBorderSource): Deleted. Canonical link: https://commits.webkit.org/281569@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed all the mask-border properties are all marked are discretely animatable, which is inconsistent with border-image properties, some of which animate by computed value.
https://drafts.csswg.org/css-backgrounds/#border-images
The text was updated successfully, but these errors were encountered: