Skip to content

[web-animations] mask-border-* properties should be animatable #31444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

[web-animations] mask-border-* properties should be animatable #31444

merged 1 commit into from
Jul 30, 2024

Conversation

@nt1m
Copy link
Member

@nt1m nt1m commented Jul 30, 2024 •
edited by webkit-early-warning-system
Loading

c6bbba7

[web-animations] mask-border-* properties should be animatable
https://bugs.webkit.org/show_bug.cgi?id=277313
rdar://132783274

Reviewed by Darin Adler.

Spec resolution: w3c/fxtf-drafts#529 (comment)
Spec PR: w3c/fxtf-drafts#565

mask-border-* properties should match border-image-* properties in terms of animation.

* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation.html: Added.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added.
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
(WebCore::RenderStyle::setMaskBorderSource):
(WebCore::RenderStyle::setMaskBorderSliceFill):
(WebCore::RenderStyle::setMaskBorderSlices):
(WebCore::RenderStyle::setMaskBorderWidth):
(WebCore::RenderStyle::setMaskBorderOutset):
(WebCore::RenderStyle::setMaskBorderHorizontalRule):
(WebCore::RenderStyle::setMaskBorderVerticalRule):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::maskBorderHorizontalRule const):
(WebCore::RenderStyle::maskBorderOutset const):
(WebCore::RenderStyle::maskBorderSlices const):
(WebCore::RenderStyle::maskBorderVerticalRule const):
(WebCore::RenderStyle::maskBorderWidth const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setMaskBorder):
(WebCore::RenderStyle::setMaskBorderSource): Deleted.

Canonical link: https://commits.webkit.org/281569@main

f89e1cb

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested a review from graouts as a code owner July 30, 2024 05:59
@nt1m nt1m self-assigned this Jul 30, 2024
@nt1m nt1m added the Animations Bugs related to CSS + SVG animations and transitions label Jul 30, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 30, 2024 •
edited
Loading

EWS run on previous version of this PR (hash bd26695)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe ✅ 🛠 wincairo
  🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ⏳ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2
  🛠 tv
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@nt1m nt1m force-pushed the eng/web-animations-mask-border--properties-should-be-animatable branch from bd26695 to 1f4395d Compare July 30, 2024 06:03
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 30, 2024 •
edited
Loading

EWS run on previous version of this PR (hash 1f4395d)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
  🛠 tv
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@nt1m nt1m force-pushed the eng/web-animations-mask-border--properties-should-be-animatable branch from 1f4395d to c6be8dd Compare July 30, 2024 06:58
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 30, 2024 •
edited
Loading

EWS run on previous version of this PR (hash c6be8dd)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2
  🛠 tv
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 30, 2024
@nt1m nt1m removed the merging-blocked Applied to prevent a change from being merged label Jul 30, 2024
@nt1m nt1m force-pushed the eng/web-animations-mask-border--properties-should-be-animatable branch from c6be8dd to f89e1cb Compare July 30, 2024 08:34
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jul 30, 2024 •
edited
Loading

EWS run on current version of this PR (hash f89e1cb)

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@nt1m nt1m requested review from darinadler, grorg, heycam and smfr July 30, 2024 08:35
@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Jul 30, 2024
@nt1m
[web-animations] mask-border-* properties should be animatable
c6bbba7 
https://bugs.webkit.org/show_bug.cgi?id=277313
rdar://132783274

Reviewed by Darin Adler.

Spec resolution: w3c/fxtf-drafts#529 (comment)
Spec PR: w3c/fxtf-drafts#565

mask-border-* properties should match border-image-* properties in terms of animation.

* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-composition.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-outset-interpolation.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-composition.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation-stability.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-slice-interpolation.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-composition.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-width-interpolation.html: Added.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/animations/mask-border-source-interpolation-expected.txt: Added.
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::conservativelyCollectChangedAnimatableProperties const):
(WebCore::RenderStyle::setMaskBorderSource):
(WebCore::RenderStyle::setMaskBorderSliceFill):
(WebCore::RenderStyle::setMaskBorderSlices):
(WebCore::RenderStyle::setMaskBorderWidth):
(WebCore::RenderStyle::setMaskBorderOutset):
(WebCore::RenderStyle::setMaskBorderHorizontalRule):
(WebCore::RenderStyle::setMaskBorderVerticalRule):
* Source/WebCore/rendering/style/RenderStyle.h:
* Source/WebCore/rendering/style/RenderStyleInlines.h:
(WebCore::RenderStyle::maskBorderHorizontalRule const):
(WebCore::RenderStyle::maskBorderOutset const):
(WebCore::RenderStyle::maskBorderSlices const):
(WebCore::RenderStyle::maskBorderVerticalRule const):
(WebCore::RenderStyle::maskBorderWidth const):
* Source/WebCore/rendering/style/RenderStyleSetters.h:
(WebCore::RenderStyle::setMaskBorder):
(WebCore::RenderStyle::setMaskBorderSource): Deleted.

Canonical link: https://commits.webkit.org/281569@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/web-animations-mask-border--properties-should-be-animatable branch from f89e1cb to c6bbba7 Compare July 30, 2024 16:11
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jul 30, 2024

Committed 281569@main (c6bbba7): https://commits.webkit.org/281569@main

Reviewed commits have been landed. Closing PR #31444 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c6bbba7 into WebKit:main Jul 30, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darinadler darinadler darinadler approved these changes

@graouts graouts Awaiting requested review from graouts graouts is a code owner

@smfr smfr Awaiting requested review from smfr

@grorg grorg Awaiting requested review from grorg

@heycam heycam Awaiting requested review from heycam

Assignees

@nt1m nt1m

Labels

Animations Bugs related to CSS + SVG animations and transitions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nt1m @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot