Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Shwetank issue1104 remove anchor point #1152

Merged
merged 3 commits into from
Jan 24, 2018

Conversation

shwetank
Copy link
Contributor

Removed portion related to anchor-point as referred to in issue 1104

Pinging @chaals for review.

Copy link
Collaborator

@chaals chaals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the change to the changes section.
I think you need to remove the property-index bit around line 1158 in single-page.bs so we don't get a property index, but my bikeshed fu is weak, and weaker in transit as I am now.

@shwetank
Copy link
Contributor Author

@chaals I added the bit in the changes section now.

Regarding the property index - I built the spec locally and in the single-page.html it no longer had the index for anchor-points. (i.e, in fpwd, the dialog element is 4.11.4 and the anchor-point stuff is 4.11.4.1, but with this change its just the dialog element - 4.11.1, and the index and contents for 4.11.4.1 are just not there anymore now).

I hope that works, otherwise we can discuss more on what else is needed exactly.

@chaals chaals merged commit 90f7c21 into master Jan 24, 2018
@shwetank shwetank deleted the shwetank-issue1104-remove-anchor-point branch January 25, 2018 05:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants