This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Remove §4.2.5.4. Other pragma directives #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaals
reviewed
Feb 17, 2018
There was a problem hiding this comment.
The changes look good.
There should be a note in the changes section (changes.include - hopefully it is pretty self-explanatory), since this does actually make a substantive change.
Also, you should update the acknowledgements section to add yourself, and "programmer3000" as contributors to this version. Again, I hope the format is pretty straightforward.
Thank you for the PR. If you prefer, I can complete it from here, or if you make those changes I will merge it.
|
Thanks @chaals—I've made the requested updates. |
|
Marked as non substantive for IPR from ash-nazg. |
chaals
approved these changes
Feb 18, 2018
plehegar
pushed a commit
that referenced
this pull request
Feb 18, 2018
scottaohara
pushed a commit
that referenced
this pull request
Feb 19, 2018
Fix #1212 * Removed §4.2.5.4. Other pragma directives Substantive change, and noted, but there are no implementation requirements implied by this change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue outlined in #1212.
This is my first PR for the repo—I have read
CONTRIBUTING.mdand I believe its changes adhere to the document's guidelines. If not, please let me know and I'll happily make the required changes.