Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Add callout to detach from a media element #157

Merged
merged 2 commits into from
Apr 8, 2016
Merged

Add callout to detach from a media element #157

merged 2 commits into from
Apr 8, 2016

Conversation

travisleithead
Copy link
Member

Addressing Issue #155

@foolip
Copy link
Member

foolip commented Mar 22, 2016

Attribution of whatwg/html@cf9e802 in the commit message would be nice.

Based on whatwg/html@ cf9e802.
@travisleithead
Copy link
Member Author

Attribution of whatwg/html@ cf9e802 in the commit message would be nice.

Yes, missed that, sorry. Attributed lamely in followup commit.

@foolip
Copy link
Member

foolip commented Mar 23, 2016

One can update a PR in-place with git push -f for prettier history, unless you really want to split it over multiple commits.

@domenic
Copy link

domenic commented Mar 24, 2016

Traditionally attribution is in the Acknowledgments section.

@foolip
Copy link
Member

foolip commented Mar 25, 2016

To be clear, what I meant was just that the commit message should say where the spec text came from. The role of the WHATWG editors should of course be clearly documented as well, see 4e0d7bb

@jdsmith3000
Copy link

When might this PR be reviewed? MSE has a dependent PR (MSE PR #56) waiting to be committed.

@domenic
Copy link

domenic commented Mar 25, 2016

Since HTML 5.1 does not meet the normative reference policy anyway, it might be best to just reference WHATWG HTML in the interim.

@chaals chaals merged commit e3682fa into w3c:master Apr 8, 2016
W3C-HTML-Bot pushed a commit that referenced this pull request Apr 8, 2016
@travisleithead travisleithead deleted the detach-from-media-element branch April 8, 2016 22:15
: Media Capture and Streams
:: The following term is defined in the Media Capture and Streams specification: [[!MEDIACAPTURE-STREAMS]]

* {{MediaStream}} [[!MEDIACAPTURE-STREAMS]]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every piece of action is caught only machine input

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants