This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Fix all FATAL ERRORs when using the latest [evergreen] bikeshed in master branch #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #707 Bikeshed updates have made the following unnecessary: 1. idl dfn attributes to mark which interface they use 2. for attributes on elements -- reworking the two cases we have in the spec for this (source and title) Found other bugs exposed by this bikeshed update in our spec, namely around use of enum, that should have been enum-value.
W3C-HTML-Bot
pushed a commit
that referenced
this pull request
Nov 29, 2016
…t [evergreen] bikeshed in master branch (#727)
arronei
pushed a commit
to arronei/html
that referenced
this pull request
Apr 17, 2017
…ster branch (w3c#727) * Fix w3c#707 Fix w3c#707 Bikeshed updates have made the following unnecessary: 1. idl dfn attributes to mark which interface they use 2. for attributes on elements -- reworking the two cases we have in the spec for this (source and title) Found other bugs exposed by this bikeshed update in our spec, namely around use of enum, that should have been enum-value. * Finish merge of <source> element, and related cleanup. * final changes to fix fatal-errors during build process
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the master branch only (see issue #707). Note, only FATAL ERRORs are addressed--there are still numerous WARNING-level issues to tackle. These will be addressed by #726.
The most substantive change is to merge the multiple definitions of the
<source>element back into one. This is in alignment with the WHATWG. It never made sense to try to track two separate definitions of the<source>element, and this change fixes that by merging them.Other minor changes include how IDL blocks don't need to use the
forattribute, and some typos and duplicated information. The spec is still not using the latest bikeshed to build from (it's using the dated snapshot). We may not want to freshen that snapshot in the build system until all the warnings are also fixed.