Make the Japanese and English termref consistent #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himorin
approved these changes
Jan 29, 2024
|
@kidayasuo agenda+ for 6 Feb. |
kidayasuo
reviewed
Feb 14, 2024
himorin
reviewed
Feb 14, 2024
| @@ -394,9 +394,9 @@ <h4 id="principles_of_arrangement_of_kanji_and_kana_characters"> | |||
| <span its-locale-filter-list="ja" lang="ja">漢字及び仮名の配置の原則</span> | |||
| </h4> | |||
| <p its-locale-filter-list="en" lang="en">In principle, when composing a line with <a class="characterClass" href="#cl-19">ideographic (cl-19)</a>, <a class="characterClass" href="#cl-15">hiragana (cl-15)</a> and <a class="characterClass" href="#cl-16">katakana (cl-16)</a> characters no extra spacing appears between their <a href="#term.character-frame" class="termref">character frame</a>. | |||
| This is called solid setting | |||
| This is called <a href="#term.solid-setting" class="termref">solid setting</a> | |||
There was a problem hiding this comment.
Suggested change
| This is called <a href="#term.solid-setting" class="termref">solid setting</a> | |
| This is called <a href="#term.solid-setting" class="termref">solid setting</a> |
|
merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The termref for "character frame" is not in Japanese and "ベタ組" is not in English.
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Jan 29, 2024, 5:53 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.