Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for @json field testcase in framing #144

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Added tests for @json field testcase in framing #144

merged 3 commits into from
Dec 19, 2022

Conversation

pasquale95
Copy link

As suggested in the issue #142, I've added a test collection to better define what is expected when framing over a @json field.

@w3cbot
Copy link

w3cbot commented Dec 17, 2022

gkellogg marked as non substantive for IPR from ash-nazg.

@gkellogg
Copy link
Member

I updated your branch with the manifest entries required. Without the suggested update, the result will be in the expanded form:

{
  "@context": {
    "ex": "http://example.org/vocab#"
  },
  "@id": "http://example.org/test/#library",
  "@type": "ex:Library",
  "ex:info": {
    "@value": {
      "author": "JOHN",
      "pages": 200
    },
    "@type": "@json"
  }
}

But, it fails with the update, which will require some investigation.

@gkellogg
Copy link
Member

I've updated this to be a passing test.

@gkellogg gkellogg merged commit 59d5631 into w3c:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants