This repository has been archived by the owner on Nov 11, 2019. It is now read-only.
Update RDFa algorithm to reflect Ruby Microdata to RDF implementation. #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tell me how to make an IPR commitment, and presumably this will clear the check. |
|
The best way would be to join the WG as it will cover future contributions. |
|
Done. I’m now in the WG. |
gkellogg
commented
Nov 14, 2017
| <p class="note">The choice of element is left to the author, to provide sufficient flexibility | ||
| to avoid unwanted changes in the rendering of the content.</p> | ||
| <li>Replace the <a>itemscope</a> attribute with a <code>vocab</code> attribute, whose value is the <a>vocabulary identifier</a> for the item.</li> | ||
| <li>Replace any <a>itemtype</a> attribute with a <code>typeof</code> attribute whose value is taken from the values of <a>itemtype</a> where each type is made relative to <a>vocabulary identifier, ensuring that the element has a <code>typeof</code> attribute with at least an empty value.</a>. |
There was a problem hiding this comment.
Making these relative doesn’t really add anything, and any that are already relative will be resolved against in-scope typeof.
| <li>Replace any <a>itemid</a> attribute with a | ||
| <code>resource</code> attribute having the same value.</li> | ||
| <li>Otherwise, ensure that element has a <code>typeof</code> | ||
| attribute with at least an empty value.</li> |
There was a problem hiding this comment.
Tensuring it has typeof may not be necessary, as language elsewhere in the spec seems to require an item have an itemtype, but RDFa makes no such assumption, and it may be overkill, except for top-level items. A typeof property is necessary to create a subject node, if there is no itemid.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update reflects my implementation at https://github.com/ruby-rdf/rdf-microdata/blob/develop/lib/rdf/microdata/rdfa_reader.rb. Other than some vestiges of the Microdata to RDF Registry, this passes the Microdata to RDF test suite (once
rdfa:usesVocabularytriples are removed).Relates to #83.