Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEL cache should be partitioned #138

Closed
yoavweiss opened this issue May 22, 2023 · 4 comments · Fixed by #143
Closed

NEL cache should be partitioned #138

yoavweiss opened this issue May 22, 2023 · 4 comments · Fixed by #143
Assignees

Comments

@yoavweiss
Copy link
Contributor

#136 and the related paper point out an issue with the fact that the NEL cache is not partitioned. While in practice it is partitioned in Chromium, we should fix the spec to reflect that.

clelland added a commit to clelland/storage-partitioning that referenced this issue May 24, 2023
Mentioned in w3c/network-error-logging#138, the NEL policy cache should also be partitioned.
@clelland
Copy link
Contributor

@jyasskin suggested that we can use the storage key concept from https://github.com/whatwg/storage as a partition key in this spec.

I think we'd need a note that implementers can use stronger keys, but that should set a minimum bar. And then if Storage adopts double- or triple-keying, NEL should get that for free at that point.

@annevk
Copy link
Member

annevk commented May 26, 2023

Shouldn't it use the network partition key?

@clelland
Copy link
Contributor

Is that concept defined in a spec? I can imagine that it would be a better fit, but I'm not certain

@annevk
Copy link
Member

annevk commented May 26, 2023

Yes, in Fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants