Allow "prompt the user to choose" apply to one or more options. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyasskin
reviewed
Apr 11, 2022
|
(thanks both, will get back to this ASAP) |
|
OK, re-worked it a bit to take a boolean "allowMultiple". It seems sensible to restrict to one choice in the default case, but allow any number of choices in the non-default case. PTAL @marcoscaceres @jyasskin |
marcoscaceres
approved these changes
May 23, 2022
jyasskin
approved these changes
May 23, 2022
Co-authored-by: Jeffrey Yasskin <jyasskin@gmail.com>
|
Thanks for the feedback @jyasskin and @marcoscaceres! 🙇♂️ |
github-actions bot
added a commit
that referenced
this pull request
May 23, 2022
SHA: ccee19d Reason: push, by @miketaylr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to miketaylr/permissions
that referenced
this pull request
May 25, 2022
) SHA: ccee19d Reason: push, by @miketaylr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #375
A PR for discussion. PTAL @marcoscaceres
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on May 23, 2022, 6:26 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.