Resolve with null if not registered. #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </li> | ||
| <li>Retrieve the <a>push registration</a> associated with the <a>webapp</a>. | ||
| </li> | ||
| <li>If there is an error, reject <var>promise</var> with a <code><a>DOMException</a></code> | ||
| whose name is "<code><a>AbortError</a></code>" and terminate these steps. | ||
| and terminate these steps. |
There was a problem hiding this comment.
What kind of error is an implementation meant to throw if it's not an AbortError? Specifying the kind of DOMException still seems valuable here, even if you keep it as generic as AbortError.
|
lgtm % comment |
|
Thanks for taking a look guys. Let's just focus on making this thing nullable. The concepts of retrieving and the way to define errors should really be separate. |
mvano
added a commit
that referenced
this pull request
Jan 14, 2015
Resolve getSubscription promise with null if not subscribed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #96