Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoted triples #192

Merged
merged 22 commits into from
Aug 5, 2021
Merged

Quoted triples #192

merged 22 commits into from
Aug 5, 2021

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jul 5, 2021

  • Changed embedded triple to quoted triple in the editor's draft.
  • embTriple => quotedTriple, embSubject => qTSubject, embObject => qTObject.
  • EmbTriple => QuotedTriple, EmbTP => QuotedTP, EmbSubjectOrObject => QTSubjectOrObject, VarOrTermOrEmbTP => VarOrTermOrQuotedTP, ExprEmbTP => ExprQuotedTP.

Fixes #184.


Preview | Diff

EmbTP => QuotedTP,
EmbSubjectOrObject => QTSubjectOrObject,
VarOrTermOrEmbTP => VarOrTermOrQuotedTP,
ExprEmbTP => ExprQuotedTP.
@pchampin pchampin requested a review from hartig July 7, 2021 07:35
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
Copy link
Member Author

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits you may, or may not agree with.

cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
@gkellogg gkellogg marked this pull request as ready for review July 13, 2021 21:04
@gkellogg gkellogg requested a review from pchampin July 13, 2021 21:04
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
@TallTed
Copy link
Member

TallTed commented Jul 13, 2021

Github apparently gets confused when an in-flight review contains suggestions to text that get changed between the start and submission of that review. I re-suggested the two that leapt out at me. Hopefully everything else gets through.

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@gkellogg
Copy link
Member Author

That should have all your changes, @TallTed, thanks!

@TallTed
Copy link
Member

TallTed commented Jul 14, 2021

I'm a little concerned about not explicitly saying that the components of quoted triples are not interpreted (i.e., that quoted triples are not asserted when quoted, though they are when annotated) until discussing the examples (which discussion might well be skimmed over or ignored entirely).

It might be worth also including a plain language discussion of a quoted statement which is not asserted when quoting it, e.g., "Alice said, 'The Moon is made of Green Cheese.'", where I'm asserting that Alice stated something, but not asserting the something she stated; vs "The Moon is made of Green Cheese. Alice agreed." or the like...

@afs
Copy link
Collaborator

afs commented Jul 14, 2021

How about making:

A triple can be used as an asserted triple, a quoted triple, or both, in a given graph.

into

A triple can be used as an asserted triple, or used as a quoted triple, or both, in a given graph.

which is strengthening existing text to stress that there is no connection.

I don't think an English example can be robust enough for the document. Depending on use of " and ' is not so friendly for i18n. Not all languages quote that way.

FWIW: << was motivated by U+00AB: 'left-pointing double angle quotation mark'.

@TallTed
Copy link
Member

TallTed commented Jul 15, 2021

How about ... strengthening existing text to stress that there is no connection.

Sure, that also works. Applied above.

I don't think an English example can be robust enough for the document. Depending on use of " and ' is not so friendly for i18n. Not all languages quote that way.

I'm certainly not suggesting removal of the existing examples.

I would hope, perhaps forlornly, that someone who didn't understand the English (or multi-lingual) textual examples would take that as a hint to pay more attention to the subsequent serialization examples. The clarity of the English textual examples might improve with use of the almost comical smart quotes, ❛ ❜ ❝ ❞...

FWIW: << was motivated by U+00AB: 'left-pointing double angle quotation mark'.

Textual examples in various languages using their typical quotation marks would be a bonus. (FWIW, I find all of these in the "Emoji and Symbols" of my macOS " « » ‘ ’ ‚ ‛ “ ” „ ‟ ‹ › ❛ ❜ ❝ ❞ ❮ ❯ 〝 〞 〟 "󠀢󠀢󠀢 ❟ ❠.)

cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
tests/semantics/manifest.ttl Outdated Show resolved Hide resolved
tests/semantics/manifest.ttl Outdated Show resolved Hide resolved
tests/semantics/manifest.ttl Outdated Show resolved Hide resolved
tests/semantics/manifest.html Outdated Show resolved Hide resolved
tests/semantics/manifest.html Outdated Show resolved Hide resolved
tests/semantics/manifest.jsonld Outdated Show resolved Hide resolved
tests/semantics/manifest.jsonld Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
Change "quoted string" to "quoted triple".
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
Comment on lines 550 to 552
subject of further triples. It uses delimiters `{|` and `|}` following an asserted
triple to make that triple, as a <a>quoted triple</a>, the subject of the enclosed
RDF triples.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made previously appear to have been lost before this step... This sentence in particular was changed significantly and necessarily -- there are no "enclosed RDF triples"; there are "enclosed predicate + object pairs" (or however I phrased it previously).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been suspicious that some suggestions were lost earlier, possibly because we are doing very fine grained edits and git only looks at lines. Could you point out the changes because in the UI I see, I don't see them and also maybe close of other missed.

Here, I edited the latest github working copy as you can see from the commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to hope they've all been caught. I don't have a query that works against my brain to get the editing nits I've already picked... (One downside to such a long-lived and much-massaged PR.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been going through things that weren't merged to re-surface them; there are a couple open for @afs to review. Still, I'm sure we'll find some way to further improve the document after merge.

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reapply my previous edits...

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
@gkellogg gkellogg requested a review from pchampin July 22, 2021 00:43
afs and others added 2 commits July 22, 2021 12:25
Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net>
Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net>
cg-spec/editors_draft.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@afs
Copy link
Collaborator

afs commented Jul 29, 2021

"for merging once editors are satisfied"
https://w3c.github.io/rdf-star/Minutes/2021-07-16.html#t03

Are we ready to merge this now?

(Obviously if anything turns up it can be handled in the editors draft)

cc: @pchampin @hartig

@afs afs merged commit f6f1629 into main Aug 5, 2021
@afs afs deleted the quoted-triples branch August 5, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain "embedded triple" as a "quoted triple".
5 participants