-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quoted triples #192
Quoted triples #192
Conversation
EmbTP => QuotedTP, EmbSubjectOrObject => QTSubjectOrObject, VarOrTermOrEmbTP => VarOrTermOrQuotedTP, ExprEmbTP => ExprQuotedTP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits you may, or may not agree with.
Github apparently gets confused when an in-flight review contains suggestions to text that get changed between the start and submission of that review. I re-suggested the two that leapt out at me. Hopefully everything else gets through. |
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
That should have all your changes, @TallTed, thanks! |
I'm a little concerned about not explicitly saying that the components of quoted triples are not interpreted (i.e., that quoted triples are not asserted when quoted, though they are when annotated) until discussing the examples (which discussion might well be skimmed over or ignored entirely). It might be worth also including a plain language discussion of a quoted statement which is not asserted when quoting it, e.g., "Alice said, 'The Moon is made of Green Cheese.'", where I'm asserting that Alice stated something, but not asserting the something she stated; vs "The Moon is made of Green Cheese. Alice agreed." or the like... |
How about making:
into
which is strengthening existing text to stress that there is no connection. I don't think an English example can be robust enough for the document. Depending on use of FWIW: |
Sure, that also works. Applied above.
I'm certainly not suggesting removal of the existing examples. I would hope, perhaps forlornly, that someone who didn't understand the English (or multi-lingual) textual examples would take that as a hint to pay more attention to the subsequent serialization examples. The clarity of the English textual examples might improve with use of the almost comical smart quotes,
Textual examples in various languages using their typical quotation marks would be a bonus. (FWIW, I find all of these in the "Emoji and Symbols" of my macOS |
Change "quoted string" to "quoted triple".
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
cg-spec/editors_draft.html
Outdated
subject of further triples. It uses delimiters `{|` and `|}` following an asserted | ||
triple to make that triple, as a <a>quoted triple</a>, the subject of the enclosed | ||
RDF triples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made previously appear to have been lost before this step... This sentence in particular was changed significantly and necessarily -- there are no "enclosed RDF triples"; there are "enclosed predicate + object pairs" (or however I phrased it previously).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been suspicious that some suggestions were lost earlier, possibly because we are doing very fine grained edits and git only looks at lines. Could you point out the changes because in the UI I see, I don't see them and also maybe close of other missed.
Here, I edited the latest github working copy as you can see from the commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to hope they've all been caught. I don't have a query that works against my brain to get the editing nits I've already picked... (One downside to such a long-lived and much-massaged PR.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been going through things that weren't merged to re-surface them; there are a couple open for @afs to review. Still, I'm sure we'll find some way to further improve the document after merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reapply my previous edits...
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net>
Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
"for merging once editors are satisfied" Are we ready to merge this now? (Obviously if anything turns up it can be handled in the editors draft) |
Fixes #184.
Preview | Diff