Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar updates for triple terms and occurrences #33

Merged
merged 14 commits into from
Sep 12, 2024

Conversation

domel
Copy link
Contributor

@domel domel commented Mar 8, 2024

  • Adds tripleTerm and reification.
  • Changes annotation to allow an identifier.
  • Depends on "reification" being defined in RDF Concepts.

See w3c/rdf-turtle#51


Preview | Diff

@domel domel added the spec:substantive Issue or proposed change in the spec that changes its normative content label Mar 8, 2024
@domel domel requested a review from gkellogg March 8, 2024 09:51
Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of other things needed from w3c/rdf-turtle#51:

  • There is no qtSubject any more. But, changes in Grammar updates for triple terms and occurrences. rdf-turtle#51 are appropriate in the Parser State section.
  • From RDF Triples Constructors, we need copies of the entries for "Triple Terms", "Reifications", and "Annotations". As the grammar anchors are different, can't really use a reference, but the HTML source might be the same.
  • Changes between RDF 1.1 and RDF 1.2 should say something about triple terms, reifications, and annotations.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Show resolved Hide resolved
@domel domel requested a review from gkellogg March 10, 2024 16:05
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@gkellogg gkellogg marked this pull request as draft April 4, 2024 16:24
@gkellogg gkellogg marked this pull request as ready for review September 8, 2024 20:52
@gkellogg gkellogg requested a review from afs September 8, 2024 20:52
spec/index.html Outdated Show resolved Hide resolved
domel and others added 2 commits September 12, 2024 18:36
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@pchampin
Copy link
Contributor

pchampin commented Sep 12, 2024

This was discussed during the #rdf-star meeting on 12 September 2024.

View the transcript

w3c/rdf-turtle#68 and w3c/rdf-trig#33

gkellogg: second item (updates to turtle). I think that's ready to merge.
… then item 5 on trig. this started by Dominik_T some time ago. I did some updates to align with Turtle.
… needs more approvals.
… substantive change which is recent. but it does mirror the updates to turtle.

ora: you're saying someone else should take a look before a merge?

gkellogg: yes. look and approve. then we can merge after that.

AndyS: I can. Have done changes to the trig parser.


spec/index.html Outdated Show resolved Hide resolved
@gkellogg gkellogg merged commit 7294f21 into main Sep 12, 2024
2 checks passed
@gkellogg gkellogg deleted the triple-term-occurance branch September 12, 2024 19:42
@gkellogg gkellogg mentioned this pull request Oct 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:substantive Issue or proposed change in the spec that changes its normative content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants