refactor: use puppeteer instead of nightmare #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
Feb 8, 2018
There was a problem hiding this comment.
Impressive how little code needed to be refactored. @saschanaz, awesome work.
tools/respecDocWriter.js
Outdated
| @@ -7,7 +7,7 @@ | |||
| /*jshint node: true, browser: false*/ | |||
| "use strict"; | |||
| const os = require("os"); | |||
| const Nightmare = require("nightmare"); | |||
| const puppeteer = require('puppeteer'); | |||
There was a problem hiding this comment.
nit: double quote... I've been using prettier.js for the project.
marcoscaceres
added a commit
that referenced
this pull request
Feb 12, 2018
* develop: v19.2.0 docs(examples): use github config option (#1500) fix(tools/release): use build:components instead (#1501) fix: ping SpecRef in ordering-safe way (#1499) chore: update dependencies (#1498) fix: prevent unordered tests from conflicting (#1495) refactor: remove WebIDL array support (#1496) Feat: link to pull requests in headers Skip detectBrowsers when explicitly passing browsers (#1490) refactor: use node.js api rather than unix commands (#1488) refactor: use puppeteer instead of nightmare (#1483) chore(package): update jasmine-core to version 3.0.0 (#1481) workaround: use sudo required on travis (#1478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppeteeris a first-party wrapper library of Chromium made by Google. It directly uses Chromium instead of Electron (which again uses Chromium), and has less dependencies (80 total dependencies fornightmarewhereas 16 forpuppeteer.)This still requires a real browser (Chromium) but in a lighter way.
Ultimately, but not in this PR, we can use puppeteer-installed Chromium to be used in karma tests so that GPU-less CLI environments can use it easily.