Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependencies #1498

Merged
merged 1 commit into from Feb 12, 2018
Merged

chore: update dependencies #1498

merged 1 commit into from Feb 12, 2018

Conversation

marcoscaceres
Copy link
Member

No description provided.

@saschanaz
Copy link
Member 

FAILED TESTS:
  W3C — Bibliographic References
    ✖ displays the publisher when present
      HeadlessChrome 64.0.3282 (Linux 0.0.0)
    Error: SpecRef seems to be down. Can't proceed with this spec.
        at UserContext.it (tests/spec/core/biblio-spec.js:89:13)
        at <Jasmine>

This happens fairly frequently, Hmm.

@marcoscaceres
Copy link
Member Author

This happens fairly frequently, Hmm.

Yeah, Tobie is looking into it. We haven't been able to work out why specref keeps failing on us.

@saschanaz
Copy link
Member

saschanaz commented Feb 12, 2018 •
edited

It seems the spec tests themselves have a problem with the new jasmine ordering behavior, as "pings biblio service to see if it's running" test never fails.

@marcoscaceres
Copy link
Member Author

We might need to do some kind of check in beforeAll() https://github.com/w3c/respec/blob/develop/tests/spec/core/biblio-spec.js#L66

If I recall correctly, you said there was some way to force tests to be run in order, right? If so, we might need to enable that here. Alternatively, we could do the ping on every test.

@marcoscaceres
Copy link
Member Author

.... Let's see how bad this gets tho.

@marcoscaceres marcoscaceres merged commit 718d400 into develop Feb 12, 2018
@marcoscaceres marcoscaceres deleted the update_deps branch February 12, 2018 04:29
marcoscaceres added a commit that referenced this pull request Feb 12, 2018
@marcoscaceres
Merge branch 'develop' into gh-pages
2b22b31 
* develop:
  v19.2.0
  docs(examples): use github config option (#1500)
  fix(tools/release): use build:components instead (#1501)
  fix: ping SpecRef in ordering-safe way  (#1499)
  chore: update dependencies (#1498)
  fix: prevent unordered tests from conflicting (#1495)
  refactor: remove WebIDL array support  (#1496)
  Feat: link to pull requests in headers
  Skip detectBrowsers when explicitly passing browsers (#1490)
  refactor: use node.js api rather than unix commands  (#1488)
  refactor: use puppeteer instead of nightmare (#1483)
  chore(package): update jasmine-core to version 3.0.0 (#1481)
  workaround: use sudo required on travis (#1478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcoscaceres @saschanaz