-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old code, replace with link to repo, etc. #213
Conversation
It came to my attention that people are still using this page via GitHub.io, but since all of this information was deleted from the FPWD, it is important that this page be current to prevent misunderstandings. This commit deletes the old obsolete sampleJS code (under "code samples"), corrects some important values in the plain language tutorial and pseudocode (under the resources tab), and provides links to the GitHub repo for the authoritative APCA code and methods.
TO ADD: it appears that what is needed is for this to be applied to the gh-pages branch? Is that where the github.io link I posted in the pull request is being served? I am mainly concerned with that link as it is still live and being read. |
It removes the code sample and refers people back to Myndex for the latest code. I think this is a problem for stability and we should consider what should be in the next version and what the stable code example is for that point in time. I think linking to the Myndex repo for tool vendors who are interested in the latest thinking is good, but the code example that has been agreed on by the group should be stable and in the code example tab. Discuss in the next editor's meeting. |
This pull request is only for this very old version which is FAR out of date, but still seems to be referenced and shows up on Google. I'd like to point out that someone removed all code samples from the FPWD not to mention removing all descriptions of how APCA works, so the FPWD says nothing about the mechanism of APCA, and only shows the (also now out of date) lookup table. The W3 currently does not show any documentation of the current, functioning, accurate version of APCA, and nothing even close. Andy |
@jspellman And to add: there is a version that is stable enough to go in the FPWD, but there is literally nothing there — I could make a pull request for that, but as all the code and descriptions were summarily deleted without consulting me, I've had no idea what the intent is for FPWD. REGARDLESS, THIS pull request is only about removing long obsolete code that is still being linked to and MUST BE REMOVED ASAP PLEASE. |
As evidenced in issue #443 this obsolete code is continuing to cause confusion. What can I do to help expedite this pull request please? |
@jspellman @rachaelbradley @michael-n-cooper Please merge this to resolve comments associated with #443 on obsolete code issues. |
@jspellman said
The problem for STABILITY is continuing to have an ALPHA level version of code ANYWHERE that is public facing while at the same time DELETING (without comment) the more correct code I had placed in the FPWD. THIS CODE HERE needs to be removed, it is causing problems with wrong and incompatible code in the wild. It's been almost a year since I opened this pull request, and the code here is wrong and needs to be removed. The current base code is 0.98G-4g, and is stable other than there will be a small change to allow other colorspaces like P3 easier integration. But this old Alpha level code is obsolete and needs to be deleted. |
Okay, in lieu of pull request w3c#213, this pull request addresses Jeanne's concerns and also get the bod information away from any links. TO BE CLEAR: the document this pull request is correcting **was never supposed to be public facing and linked** per my understanding — but the correct code was deleted from the FPWD, yet in this doc was BAD OBSOLETE CODE that should have been replaced by the FPWD. This document is STILL LINKED, and now there are several instances of bade code in the wild as a result. For reasons that are unclear, the links to this BAD CODE keep popping up as if someone is attempting to sabotage this project. PLEASE PUSH THIS PULL REQUEST THROUGH. This supersedes the previous request (w3c#213) In THIS request, I left the code and only find the things that would have been fixed if the correct code was not deleted from the FPWD.
As this PR has not ben acted on there is a new PR #570 that effects the needed changes, addressing all of Jeanne's notes. |
Hey folks, what is the status on this PR? I'm trying to get a sense of what exactly WCAG 3.0 specifies for text contrast, which seems to be very little, and am also finding links to old/orphaned resources like this one Actually normatively referencing or including the various constants used in the APCA algorithm would make things much easier. But at minimum, removing obsolete code versions would help clarity greatly. |
BUMP.I would like to point out that THIS WRONG CODE shown in "code samples" on THIS LINK is the SOURCE of much the controversy and certain problems in recent months, INCLUDING the one relating to "compliance" that Rachael posted about on LinkedIn and in her blog.THIS LINK still exists in public facing form with NO DISCLAIMER that it is deprecated nor even that it is "draft". Do you see how this is being misinterpreted? It is still linked to widely and the links pointing herein make statements such as "The new WCAG 3". Yet as this pull request has still not been merged, the links result in WRONG MATERIAL that is not even close to current, and was never intended to be public facing as is. Honestly, there is no excuse for this. On the real working draft, there is a disclaimer at the top indicating it is a draft. Yet that does not exist here. And THIS LINK is STILL live and still being referenced all over the net. While I was able to get the "very bad" example on Figma taken down, there are too many that are out of reach. THIS PULL REQUEST has been sitting here for nearly two years, continuing to do damage to the understanding and forward development of APCA. What is it going to take to either DELETE the page/link entirely, or to merge this pull request? Please merge this request.Leaving it up is an obstruction to the stable development and progress of the APCA and WCAG_3 guidelines. |
OBE by #663 |
It came to my attention that people are still using this page via GitHub.io, but since all of this information was deleted from the FPWD, it is important that this page be current to prevent misunderstandings (some have already occured).
This commit deletes the old obsolete sampleJS code (under "code samples"), corrects some important values in the plain language tutorial & pseudocode (under the "resources" tab), and provides links to the GitHub repo for the authoritative APCA code and methods.
Thank you,
Andy