Renames 'eval' function introduced in ALP to 'reachableTerms' #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tpt
approved these changes
Sep 22, 2025
afs
approved these changes
Sep 23, 2025
rubensworks
approved these changes
Sep 24, 2025
Added via commit 86632a0 |
kasei
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #268 (comment), the definition of the ALP function (used for defining property paths) introduces a function called "eval". Due to its name, this function may easily be confused with the eval function used to define the evaluation semantics of algebraic query expressions.
To avoid such confusion, this PR renames the function to reachableTerms (which also reflects more closely what the function actually does).
Additionally, the PR makes this function name linkable (with an HTML anchor) and turns the two uses of the function into links that link back to the definition of the function.
Preview | Diff