Clarify behavior when receiving a tracestate header without traceparent #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the processing model was written, it can be interpreted such that a tracing system that receives a tracestate header without an accompanying traceparent header is valid, and that it should append to and propagate that tracestate. This commit clarifies that a tracestate header received without a traceparent header is invalid, and a new tracestate should be created.
mtwo
approved these changes
Jul 25, 2019
AloisReitbauer
approved these changes
Jul 25, 2019
|
Marked as non substantive for IPR from ash-nazg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there is an issue with the the processing model as it is currently written. The spec says:
Therefore, receiving a
tracestateheader without atraceparentshould be an invalid case.The No traceparent Received section can be interpreted such that a tracing system that receives a
tracestateheader without an accompanyingtraceparentheader should append to and propagate thattracestate. This commit clarifies that atracestateheader received without atraceparentheader is invalid. The receivedtracestateheader should be discarded and a newtracestateshould be created.There's a chance I'm mistaken. If am, perhaps we could find a way to clarify this situation further in the spec.