Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify tts:direction on <p> #331

Merged
merged 4 commits into from
Jan 31, 2018
Merged

Conversation

palemieux
Copy link
Contributor

Closes #324

@palemieux palemieux added this to the 3rd Ed milestone Jan 16, 2018
@palemieux palemieux self-assigned this Jan 16, 2018
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to review this because I feel my knowledge of Unicode bidi embedding is not good enough yet.

@palemieux
Copy link
Contributor Author

@nigelmegitt It is intended to match TTML2 exactly.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change matches the equivalent text in TTML2.

@palemieux
Copy link
Contributor Author

Looks like this will need to be updated to match w3c/ttml2#264

@palemieux
Copy link
Contributor Author

@nigelmegitt Updated per w3c/ttml2#562. Please review.

@palemieux palemieux removed the blocked label Jan 30, 2018
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a couple of further tweaks to match w3c/ttml2#562.

defines the directionality of an embedding or override according to
the Unicode bidirectional algorithm.</p>
<p>The <att>tts:direction</att> attribute is used to specify a style property that, depending on the context of use,
determines (1) the bidirectional paragraph level, or (2) the directionality of a bidirectional embedding or override.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra clause in https://github.com/w3c/ttml2/pull/562/files#diff-5ac39ab39265717d36dfd789d254ce1aR8859 that should probably be brought in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nigelmegitt I was not happy with the English "about which see". It seemed easiest to remove since UAX9 is already referenced below.

Copy link
Contributor

@nigelmegitt nigelmegitt Jan 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palemieux I don't see anything wrong with "about which see", but I see what you mean about UAX9 being mentioned later, and I agree the clause is not essential here.

spec/ttml1.xml Outdated
@@ -11610,6 +11614,12 @@ Agent Accessibility Guidelines 1.0</titleref>, W3C Recommendation, 17
December 2002. (See
<xspecref href="http://www.w3.org/TR/2002/REC-UAAG10-20021217/">http://www.w3.org/TR/2002/REC-UAAG10-20021217/</xspecref>.)
</bibl>
<bibl id="uax9" key="UAX9">M. Davis, A. Lanin, and A. Glass, <titleref
href="http://www.unicode.org/reports/tr9/tr9-35.html">Unicode Bidirectional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to tr9-37, and the date changed also.

@palemieux palemieux merged commit ef27916 into master Jan 31, 2018
@skynavga skynavga deleted the issue-324-clarify-tts-direction-on-p branch March 11, 2018 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants