Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of tts:fillLineGap does not match itts:fillLineGap as specified in IMSC 1.0.1. #15

Open
palemieux opened this issue Sep 28, 2017 · 20 comments
Labels
substantive Substantive change required.
Milestone

Comments

@palemieux
Copy link

itts:fillLineGap as specified in IMSC 1.0.1 has been adopted by the industry.

tts:fillLineGap definition should be copied from IMSC 1.0.1, using the IMSC namespace, so that future versions of IMSC can reference TTML2.

@skynavga
Copy link
Collaborator

skynavga commented Sep 28, 2017 via email

@css-meeting-bot
Copy link
Member

The Working Group just discussed fillLineGap, and agreed to the following resolutions:

  • SUMMARY: Majority view in favour of aligning semantics and syntax between IMSC 1.0.1 and TTML2, partly constrained by existing implementation work and adoption.
The full IRC log of that discussion <nigel> Topic: fillLineGap
<nigel> github-bot: https://github.com/w3c/ttml2/issues/429
<nigel> github: https://github.com/w3c/ttml2/issues/429
<nigel> Andreas: Thanks for raising this, I support it, and wanted to check it myself.
<nigel> .. As itts:fillLineGap is a complicated attribute, I see problems implementing it, and in
<nigel> .. compatibility, so it makes sense to keep the namespace.
<nigel> Pierre: We might do something subtler like reference IMSC 1.0.1 from TTML2, and then
<nigel> .. remove it from IMSCv.next. What's really bad is today the syntax and semantics don't
<nigel> .. match.
<nigel> s/syntax and/
<nigel> .. It's hard to understand if the TTML2 semantics are the same as the IMSC 1.0.1 semantics
<nigel> .. because the wording is so different.
<nigel> .. Either the wording is insufficient in IMSC 1.0.1 and should be fixed there or it should be
<nigel> .. made the same in TTML2. Implementers need to know that the behaviour is the same.
<nigel> Nigel: Okay, alignment is the issue here - we should define something with the same
<nigel> .. semantics in the same way.
<nigel> Pierre: I'd extend that to the namespace too.
<nigel> Andreas: I mentioned it before - there has been a bad experience changing namespaces
<nigel> .. going from the ttaf namespace to the ttml namespace, which broke things unnecessarily.
<nigel> Nigel: I can see the issue about namespaces - ideally the profile should be a pure profile
<nigel> .. of the spec, and not have this zigzagging up between the profile and the base spec.
<nigel> Pierre: Yes, in the future, maybe we just have the definition in TTML2 and remove it from
<nigel> .. IMSC, just referencing it by feature designator.
<nigel> SUMMARY: Majority view in favour of aligning semantics and syntax between IMSC 1.0.1 and TTML2, partly constrained by existing implementation work and adoption.

@skynavga
Copy link
Collaborator

skynavga commented Sep 28, 2017 via email

@palemieux
Copy link
Author

palemieux commented Sep 28, 2017

I can probably support an approach that incorporates the syntax from IMSC
and the semantics, to the extent that this is possible

I would also use the IMSC namespace, so that IMSCvNEXT can simply reference TTML2.

@skynavga
Copy link
Collaborator

skynavga commented Sep 29, 2017 via email

@andreastai
Copy link

(I add this wide review comment to the existing issue to avoid duplication)

Syntax (including IMSC namespace), prose and examples of the tts:lineGap feature should be exactly as defined in IMSC 1.0.1. Keeping syntax, prose and examples identical signals to the industry that implementation of this feature is a long term investment.

The IMSC 1.0.1 specification text represents also the latest agreement of the group regarding this feature. The new text seem not to add any change of presentation processor behaviour. It is therefore not needed.

If it is not possible to keep syntax, prose and examples identical it may be best to remove this feature from the TTML2 draft. In this case the only reference to use it, will be IMSC 1.0.1 or an upcoming version of IMSC.

@skynavga skynavga changed the title tts:fillLineGap definition does not match itts:fillLineGap as specified in IMSC 1.0.1 The definition of tts:fillLineGap does not match itts:fillLineGap as specified in IMSC 1.0.1 Oct 2, 2017
@skynavga skynavga changed the title The definition of tts:fillLineGap does not match itts:fillLineGap as specified in IMSC 1.0.1 Definition of tts:fillLineGap does not match itts:fillLineGap as specified in IMSC 1.0.1. Oct 2, 2017
@skynavga
Copy link
Collaborator

I'm beginning to have second thoughts about making normative use of a non-TTML namespace in TTML2. If the argument here is we should adopt itts:fillLineGap instead of defining a TTML2 namespace form, tts:fillLineGap, then why wouldn't this same argument be used for

  • ittp:aspectRatio rather than ttp:displayAspectRatio
  • smpte:backgroundImage rather than tts:backgroundImage
  • ebutts:linePadding
  • ebutts:multiRowAlign

etc.

An IMSCvNext document that wants to be compatible with both TTML2 and IMSC1 could simply specify both flavors of the property. TTML2 processors will ignore the itts flavor and IMSC1 processors will ignore the tts flavor.

Wouldn't IMSCvNext documents already have to do something like this for all other mechanism for which TTML2 does not adopt the exact IMSC1 syntax?

@palemieux
Copy link
Author

I do not think the same argument applies to all IMSC 1.0.1 extensions. For instance:

  • in the case of smpte:backgroundImage, it might be that there are features of TTML2 image, e.g. content type signaling, that are desirable in IMSC 1.1 and not available in smpte:backgroundImage. In that case, smpte:backgroundImage would be deprecated and TTML2 image would be used instead in IMSC 1.1. This is the situation in the FPWD of IMSC 1.1.

  • in the case of itts:fillLineGap, TTML2 does not bring anything that itts:fillLineGap does not already offer, and itts:fillLineGap is already in use. In fact, the addition of tts:fillLineGap was motivated by its presence in IMSC 1.0.1. In this case, TTML2 should match the IMSC 1.0.1 semantics exactly. In addition, it is a gratuitous pain to ask users and developers and users to use a different XML namespace in TTML2.

@skynavga
Copy link
Collaborator

skynavga commented Oct 20, 2017 via email

@palemieux
Copy link
Author

No. We jointly agreed on tts:fillLineGap at a prior meeting with the understanding that in IMSC it would use itts.

Please provide a pointer to such a decision.

Is there a difference in semantics from your interpretation? If so, we should be able to readily fix that in TTML2 for tts:fillLineGap.

The text is different, so divergence is possible. Please update the text to match IMSC 1.0.1, unless the latter is incorrect, in which case plase file an issue against IMSC 1.0.1.

t is significantly more gratuitous to require the addition of a non-TTML namespace to TTML2,
as this will have serious impact on the spec, on TTML2 processors, and, further, introduces a very bad precedent.

There is simply no meaningful on the specification, which already declares at least 10 namespaces.

There is also no meaningful precedent since itts is a W3C namespace, under W3C control.

@palemieux
Copy link
Author

Please provide a pointer to such a decision.

In fact, it looks like tts:fillLineGap was added by the TTML2 editor without a PR:

w3c/ttml2@867f1af

@skynavga
Copy link
Collaborator

skynavga commented Oct 20, 2017 via email

@palemieux
Copy link
Author

The actual property name fillLineGap was Nigel's proposal here [1]. Which came in a discussion at the London F2F where you said:

None of these discussions covered namespaces.

Adding vocabulary outside this hierarchy will require significant changes in existing schemas

The only change is adding an xmlns:itts declaration. This is not an extensive change.

require the author to add a special case xmlns:itts declaration every time they use this one style attribute, a clear and unmotivated exception to what an author (and developer) would expect.

Authors are already accustomed to multiple namespaces in IMSC1, and to associating fillLineGap with the itts namespace.

and would also raise the issue of how to deal with other vocabulary defined in the itts namespace (or a future revision).

Hopefully there is no more of this going forward, assuming TTWG is responsive to adapting TTML2 to industry needs.

@skynavga
Copy link
Collaborator

skynavga commented Oct 20, 2017 via email

@skynavga
Copy link
Collaborator

skynavga commented Oct 20, 2017 via email

@nigelmegitt
Copy link
Contributor

nigelmegitt commented Oct 23, 2017 via email

@css-meeting-bot
Copy link
Member

The Working Group just discussed Definition of tts:fillLineGap does not match itts:fillLineGap as specified in IMSC 1.0.1. #429.

The full IRC log of that discussion <nigel> Topic: Definition of tts:fillLineGap does not match itts:fillLineGap as specified in IMSC 1.0.1. #429
<nigel> github: https://github.com/w3c/ttml2/issues/429
<nigel> Nigel: The last comment on this is from me, saying we need practical proposals to address the needs of
<nigel> .. the various constituents.
<nigel> Glenn: We already don't support, say, smpte:backgroundImage, so there's a precedent for
<nigel> .. not supporting fillLineGap seems no different.
<nigel> Nigel: That's confusing - not putting smpte:backgroundImage in TTML2 doesn't mean it
<nigel> .. cannot be in a profile.
<nigel> Glenn: That's right.
<nigel> David_Ronca: We've been advocating that IMSC vNext is a subset of TTML2, but there are
<nigel> .. two ways to get to it - either make sure that there's a TTML2 equivalent feature for everything,
<nigel> .. or by bringing IMSC namespace attributes into TTML2. We prefer the former.
<nigel> .. We'd like to address the features in TTML2 not by pulling in IMSC namespace.
<nigel> Nigel: Reminder that we agreed to look at each case individually last week, and that we
<nigel> .. should do that at TPAC.
<nigel> Glenn: Makes sense to me.
<nigel> David_Ronca: We should do that, at TPAC.
<nigel> Nigel: For fillLineGap specifically I'd like more detailed proposals.
<nigel> .. We have tts:fillLineGap in TTML2 and itts:fillLineGap and they have different wording, so
<nigel> .. they may have different semantics. The goal is probably to align the semantics, and then
<nigel> .. for IMSC vNext we need to think about how to handle this if both are permitted, for all
<nigel> .. constituents.

@palemieux
Copy link
Author

As indicated in w3c/imsc#276 (comment), tts:fillLineGap is removed from TTML2

@skynavga
Copy link
Collaborator

skynavga commented Nov 11, 2017 via email

@css-meeting-bot
Copy link
Member

The Working Group just discussed Definition of tts:fillLineGap does not match itts:fillLineGap as specified in IMSC 1.0.1. ttml2#429, and agreed to the following resolutions:

  • RESOLUTION: Following further discussion, group confirms that tts:fillLineGap is to be removed.
The full IRC log of that discussion <nigel> Topic: Definition of tts:fillLineGap does not match itts:fillLineGap as specified in IMSC 1.0.1. ttml2#429
<nigel> github: https://github.com/w3c/ttml2/issues/429
<nigel> Cyril: We've discussed this today and agreed to remove `tts:fillLineGap`
<nigel> RESOLUTION: Following further discussion, group confirms that tts:fillLineGap is to be removed.

@skynavga skynavga self-assigned this Jan 15, 2018
skynavga referenced this issue in w3c/ttml2 Jan 29, 2018
@skynavga skynavga removed their assignment Jan 29, 2018
@skynavga skynavga reopened this Aug 30, 2018
@skynavga skynavga transferred this issue from w3c/ttml2 Feb 1, 2019
@skynavga skynavga added the substantive Substantive change required. label Feb 1, 2019
@skynavga skynavga added this to the 1ED-FPWD milestone Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
substantive Substantive change required.
Projects
None yet
Development

No branches or pull requests

5 participants