Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applicability of tts:rubyPosition and tts:rubyAlign. #717

Closed
spoeschel opened this issue Apr 25, 2018 · 4 comments
Closed

Applicability of tts:rubyPosition and tts:rubyAlign. #717

spoeschel opened this issue Apr 25, 2018 · 4 comments

Comments

@spoeschel
Copy link

The tts:rubyPosition attribute applies to "span only if the computed value of tts:ruby is container". IMO this does not really make sense, as the ruby container is just a general container for text with ruby annotations (it may work though in the simple ruby case).

The tt:span that is actually affected corresponds to the ruby text content or instead (if present) the ruby text container. So the attribute should instead apply to a tt:span only if the value of tts:ruby is text (only in case tt:span is not a child of a ruby text container - as all ruby text content of the same ruby text container shall have the same position) or textContainer.

The current wording also does not work if double-sided ruby is used, as when relevant on the ruby container only, it would not be possible to specify the (different) positions in case two text containers are present. The double-sided ruby example next to the definition of tts:ruby is a good example for this issue. It uses tts:rubyPosition on ruby text container level - where it cannot be applied according to the current wording.

@spoeschel spoeschel changed the title Applicability of tts:rubyPosition Applicability of tts:rubyPosition Apr 25, 2018
@cconcolato cconcolato self-assigned this Apr 26, 2018
@skynavga skynavga added this to the CR2 milestone May 10, 2018
@skynavga skynavga changed the title Applicability of tts:rubyPosition Applicability of tts:rubyPosition and tts:rubyAlign. May 12, 2018
@skynavga
Copy link
Collaborator

skynavga commented May 12, 2018

In reviewing this issue and comparing the current spec text with CSS Ruby Layout Module Level 1, I have concluded that ruby position semantically applies only to an explicit or implicit Ruby Text Container, however, syntactically speaking, we may have Ruby Text Content that is not enclosed in a syntactically explicit span with tts:ruby="textContainer", so we need to accommodate both scenarios as mentioned in this issue (above).

I have also reviewed ruby align semantics, and there are two options here: (1) to take the approach of the above cited CSS Ruby Module and state that alignment semantics applies (collectively) to Ruby Base Container, Ruby Base, Ruby Text Container, and Ruby Text; or, alternatively, (2) state that alignment semantics apply to Ruby Container as a whole, which includes alignment of its constituent areas. At present, we already do this (in the applies row of the syntax table), but we don't elaborate the meaning of this. Therefore, I will add a note that elaborates this point. [I would also note that by applying alignment to Ruby Container, that a Ruby Container has only one possible alignment, i.e., one would have to divide content among multiple Ruby Containers to obtain distinct alignments.]

@palemieux
Copy link
Contributor

then an author can specify it on any descendant

ancestor, right?

@skynavga
Copy link
Collaborator

@palemieux I edited my comment, so that text is no longer present. See the just posted PR (#740).

@palemieux
Copy link
Contributor

syntactically speaking, we may have Ruby Text Content that is not enclosed in a syntactically explicit span with tts:ruby="textContainer"

What is the use case for this? It significantly complicates processing.

I have also reviewed ruby align semantics, and there are two options here:

The two options yield identical results, right? In other words, applying tts:rubyAlign="center" to the container is identical to applying tts:rubyAlign="center" to each of its text, base, baseContainer and textContainer elements.

skynavga added a commit that referenced this issue Jun 3, 2018
Clarify application of ruby alignment and positioning (#717).
@skynavga skynavga added pr merged and removed pr open labels Jun 3, 2018
@skynavga skynavga removed their assignment Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants