Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify application of ruby alignment and positioning (#717). #740

Merged
merged 2 commits into from
Jun 3, 2018

Conversation

skynavga
Copy link
Collaborator

Closes #717.

@skynavga skynavga added this to the CR2 milestone May 12, 2018
@skynavga skynavga self-assigned this May 12, 2018
@skynavga skynavga requested a review from nigelmegitt May 12, 2018 22:23
@nigelmegitt
Copy link
Contributor

I'd appreciate a review from @cconcolato and @spoeschel (you may not be able to add reviews but you can at least add a comment to the pull request, or @TairT could add the review on behalf of IRT) as a user of Ruby and the issue opener respectively please.

@@ -11886,6 +11886,14 @@ base text is in any of the following character classes as defined by <bibref ref
<p>See <bibref ref="jlreq"/>, &sect;3.3.8, <emph>Adjustments of Ruby with Length Longer than that of the Base Characters</emph> for
further information.</p>
</note>
<p>When performing presentation processing,
<termdef id="defs-isolated-ruby-content" term="isolated ruby content"><term>isolated ruby content</term></termdef>,
namely, ruby base content or ruby text content that is specified without a ruby base container or ruby text container, respectively,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"without a ruby base container or ruby text container" - I think we should say "an enclosing" or "a parent" after "without" here

@spoeschel
Copy link

Except for the commented text passage, this fix is fine for me.

<termdef id="defs-isolated-ruby-content" term="isolated ruby content"><term>isolated ruby content</term></termdef>,
namely, ruby base content or ruby text content that is specified without a ruby base container or ruby text container, respectively,
is processed in such a manner as to imply the presence of an anonymous ruby base container and (or) anonymous ruby text container as required.
An <termdef id="defs-implied-ruby-base-container" term=""><term>implied ruby base container</term></termdef> and (or)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is processed in such a manner as to imply the presence of an anonymous ruby base container and (or) anonymous ruby text container as required.

This significantly complicates processing. Why is it allowed?

Copy link
Collaborator Author

@skynavga skynavga May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palemieux I'm not sure what you are asking. Are you asking why allow specifying text and base content without specifying a text container and base container? If so, then this comes from the original Ruby content model [1] adopted in XHTML which served as a basis for the HTML5 ruby support as well. Technically speaking, we don't have to support this minimization feature (in which case we would always require base and text containers).

It is not overly complicated to implement. TTPE supports it.

[1] https://www.w3.org/TR/2001/REC-ruby-20010531/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skynavga Ah right. Yes, text and base elements should be able to occur without parent text and base containers. I had misread the text.

However, for the application of which styles would an implied ruby base container and (or) an implied ruby text container be required?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, all of the default or fallback values of all the styles that would apply have applied to the spans had the text container or base container been present. For example, rubyAlign says

The tts:rubyAlign attribute is used to specify the position of ruby text within the inline area generated by the ruby text container annotation.

This implies there is an inline area that contains all of the glyph areas of a text container in which space distribution occurs in order to obtain alignment.

As for base container, in the context of CSS3 Ruby and JLREQ, the glyph areas of a base container may be distributed with extra whitespace in order to handle overhang constraints. For example, the default behavior regarding overhang semantics may be accommodated by either (or both) distribution of space in inline areas generated by a text container and base container (whether explicitly specified or implied).

@palemieux
Copy link
Contributor

@skynavga
Copy link
Collaborator Author

skynavga commented Jun 3, 2018

@palemieux I'd like to wrap this up; is there something you want me to change?

@skynavga
Copy link
Collaborator Author

skynavga commented Jun 3, 2018

@palemieux thanks

@skynavga skynavga merged commit f536d69 into master Jun 3, 2018
@skynavga skynavga removed their assignment Jun 3, 2018
@skynavga skynavga deleted the issue-0717-ruby-styling-applicability branch June 28, 2018 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants