Issue 0296 inline block #297
Conversation
|
Please don't merge just yet - I will review this in the next couple of days. |
There was a problem hiding this comment.
Looks mostly good, a few tweaks:
-
In the table for
tts:textAlign, in the Inherited row, it says "See prose". It would be helpful to say "Yes for p, No for span - See prose". -
The example for
tts:textAlignneeds to be updated to settts:display="inlineBlock"on thespanelements wheretts:textAlignis set. This example should be referenced also in a note in the section ontts:displaybecause it provides a useful example of where the attribute is used. -
One typo as described in a comment.
spec/ttml2.xml
Outdated
| to a <loc href="#content-vocabulary-span"><el>span</el></loc> element, then | ||
| <loc href="#terms-inline-block-display">inline block display</loc> semantics apply and the element | ||
| is a candidate for region layout and presentation. Furthermore, it is considered an error if the | ||
| <code>inlineBlock</code> value to applied to any element which is not a <loc href="#content-vocabulary-span"><el>span</el></loc> element.</p> |
There was a problem hiding this comment.
typo: s/to applied to/is applied to.
|
A question: do the sections on |
skynavga
dismissed
nigelmegitt’s stale review
Address comments, except the first comment, which violates the DRY principle.
See #296 and #146.