Add border examples #352
Merged
Add border examples #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One image for the existing example, the other with an XML example for rounded borders as per #189.
skynavga
requested changes
May 31, 2017
There was a problem hiding this comment.
On the border.png example, can you use display align before or center? It should show that the border on span extends outside the paragraph border ... or increase line height so as to get all the border. Alternatively, put the span border on a word on the first line. A border on an inline, like padding on an inline, does not affect the line height and effectively overlaps nearby marks unless adequate spacing is present.
|
@skynavga Sure. I was just adding an image to reflect the existing example fragment, I didn't modify that fragment. |
* Change first border example to set displayAlign to center and update image. * Change z-order of border rectangles so that the span’s border is drawn in front of the p’s border.
skynavga
approved these changes
Jun 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189.
One image for the existing example, the other with an XML example for
rounded borders as per #189.
Would appreciate a review especially of the border example with the red, green and blue borders - I'm not at all sure that the rendering is correct - two queries: