Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module framework (#29). #30

Merged
merged 7 commits into from
Apr 4, 2019
Merged

Conversation

skynavga
Copy link
Collaborator

Closes #29.

@skynavga skynavga added the substantive Substantive change required. label Mar 14, 2019
@skynavga skynavga added this to the 1ED-FPWD milestone Mar 14, 2019
@skynavga skynavga self-assigned this Mar 14, 2019
spec/ttml3.xml Outdated Show resolved Hide resolved
Copy link

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Specified Style Set Processing procedure needs to be revised to allow Styling Attributes not listed in 10.2. See also https://www.w3.org/TR/ttml-imsc1.1/#style-resolution-procedure.

Also, can module define additional content elements?

spec/ttml3.xml Show resolved Hide resolved
spec/ttml3.xml Show resolved Hide resolved
spec/ttml3.xml Show resolved Hide resolved
spec/ttml3.xml Show resolved Hide resolved
spec/ttml3.xml Show resolved Hide resolved
@nigelmegitt
Copy link
Contributor

Thanks for opening this @skynavga - it's really useful to have something concrete to use as the basis for discussion, and has already raised some useful points.

@skynavga
Copy link
Collaborator Author

skynavga commented Mar 16, 2019

@palemieux re: #30 (review), I added the necessary hooks to 10.4.4.2 (6) and 10.4.4.4, the latter effectively extending [styled element] to potentially include a styled element defined in a (supported) external module;

I am open to considering supporting the ability to define new content elements in an external module, which would require tweaking the definition of [content element]; indeed, one could argue that if we augment 10.4.4.4 (as described above), we should also allow augmenting [content element], for what would be an (external module defined) styled element that is not a content element;

@skynavga
Copy link
Collaborator Author

skynavga commented Mar 16, 2019

@palemieux continuing my previous response to your original comment (#30 (review)), we could mandate (in a "requirements for registration" section of the module registry) that only the TTWG can define new content elements in public modules

spec/ttml3.xml Outdated Show resolved Hide resolved
@nigelmegitt
Copy link
Contributor

I'd like opinions of the terms "private" and "public" as used here with modules. There's a connotation there that somehow the private modules are not public visible, which may well not be the case. Perhaps use "registered" (in place of public) and "unregistered" (in place of private), to avoid giving a misleading impression?

@nigelmegitt nigelmegitt added the agenda Issue marked for discussion in the next call label Mar 19, 2019
@palemieux
Copy link

Support for modules should be moved to TTML2 since it is used today, e.g. by IMSC, and does not introduce conformance changes for existing implementations,

spec/ttml3.xml Show resolved Hide resolved
@palemieux
Copy link

continuing my previous response to your original comment (#30 (review)), we could mandate (in a "requirements for registration" section of the module registry)
that only the TTWG can define new content elements in public modules

@skynavga I am not sure this is necessary since foreign elements (from modules) will be pruned by implementations unaware of the module.

@skynavga
Copy link
Collaborator Author

@palemieux #30 (comment) we use content elements in a number of critical points in TTML algorithms, so allowing a module to add a content element would be potentially dangerous if we allow other parties to do so; if we want to allow a content element defined in a module, then the TTWG needs to be in 100% control of that process

@skynavga skynavga dismissed stale reviews from palemieux and nigelmegitt March 21, 2019 20:41

For re-review.

@skynavga
Copy link
Collaborator Author

@palemieux @nigelmegitt removed [{public,private} module] definitions

@palemieux
Copy link

@skynavga Thanks. Is there a diff available, or not yet?

@nigelmegitt
Copy link
Contributor

@palemieux we haven't got diffs set up for this repo as yet - this is on @plehegar 's list.

@skynavga
Copy link
Collaborator Author

@palemieux no, unfortunately, the automatic preview/diff mechanism used for respec based specs does not work for xml based specs (or html for that matter); best to use the Files Changed link above

@skynavga
Copy link
Collaborator Author

skynavga commented Apr 4, 2019

@skynavga skynavga merged commit da2f207 into master Apr 4, 2019
@skynavga skynavga deleted the issue-0029-module-framework branch April 4, 2019 23:10
@skynavga skynavga removed the agenda Issue marked for discussion in the next call label Apr 4, 2019
@skynavga skynavga removed their assignment Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
substantive Substantive change required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants