Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in description of FnLock #19

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Fix syntax error in description of FnLock #19

merged 1 commit into from
Mar 31, 2016

Conversation

cvrebert
Copy link
Member

Use curly braces instead of angle brackets. The rendered spec currently has the literal word "KEYCAP" in it.

@garykac
Copy link
Member

garykac commented Mar 31, 2016

There's a check failure "PR has contribution issues. The following users were unknown: @cvrebert".

@cvrebert
Copy link
Member Author

https://github.com/w3c/uievents-key/blob/gh-pages/CONTRIBUTING.md

To make substantive contributions to specifications,

I would argue this isn't substantive since it's just a typo fix.

you must either participate in the relevant W3C Working Group

Doesn't sound feasible.

or make a non-member patent licensing commitment.

I don't see any link/instructions on how to do that.

@cvrebert
Copy link
Member Author

Or maybe this is just a matter of adding another email to my W3C account...

@cvrebert
Copy link
Member Author

Well, that improved things slightly. Now it complains about group membership instead of "unknown user".

@garykac
Copy link
Member

garykac commented Mar 31, 2016

Good point. I forgot that typo fixes (and the like) don't require this.

@garykac garykac merged commit b8b23c8 into w3c:gh-pages Mar 31, 2016
@cvrebert cvrebert deleted the patch-4 branch March 31, 2016 01:30
@garykac
Copy link
Member

garykac commented Mar 31, 2016

Thanks for taking to time to tell us about these problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants