Add note about Tradeverifyd. #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigBlueHat
requested review from
PatStLouis,
TallTed,
brentzundel,
iherman and
msporny
msporny
approved these changes
Mar 3, 2025
|
Merging as this statement is needed to be manually added per the last VCWG meeting. |
iherman
reviewed
Mar 3, 2025
There was a problem hiding this comment.
I wonder whether some explanation would be helpful here. Tradeverifyd made a claim, which is fine, but they are not part of the formal test suite results because… what?
My understanding is that they had difficulties to combine the structure of their implementation with the particulars of the test suite and its runner. Which is a perfectly valid argument, and better make it clear in this comment imho, to avoid unnecessary questions.
|
Ouch. That was merged before I could comment. @msporny @BigBlueHat @brentzundel, can you still look at my comment above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61.