-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first pass at reserved properties table #1097
Conversation
The definition of ToU in the table conflicts with the current ToU definition in the main body of the specification. Is it proposed that the main section on ToU will be deleted from v2 DM or left in with along with its addition to the reserved properties? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for a starting point
</td> | ||
</tr> | ||
<tr> | ||
<td>`evidence`</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to reserve this term URL here, as well:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. I plan to make a revision of the vocabulary document, as well as the yml2vocab tool (so that experimental terms are presented separately) if and when these PR are merged.
index.html
Outdated
</td> | ||
</tr> | ||
<tr> | ||
<td>`renderMethod`</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to reserve new URL for this under W3C or W3ID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need time to think about this (i was travelling the last couple of weeks)
index.html
Outdated
<tbody> | ||
<tr> | ||
<td>`confirmationMethod` / `confidenceMethod`</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll accept this PR as-is since there's an issue in here. Just expressing my preference:
<td>`confirmationMethod` / `confidenceMethod`</td> | |
<td>`confidenceMethod`</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't agreed on either yet. I'd prefer to keep both until we resolved the naming discussion.
@msporny Would we still add sections to the VC Directory for "reserved" properties? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think it makes sense to have a property that is both defined in the V2DM and is included in the reserved properties table. They should be mutually exclusive, since a property in the V2DM is automatically reserved. Consequently this PR should strike out each of the sections in the DM that are included in the reserved properties table.
This is my Editorial option, and opinion as a manager of the VC Specs Directory -- yes, we would add sections to the VC Specs Directory for all reserved properties. One of the reasons for the table is to establish which extension sections exist in the VC Specs Directory. Others in the group might disagree with this notion, but if we don't have this mechanism to establish sections in the VC Specs Directory, then the question becomes "Then exactly what establishes those sections?". |
I cannot approve until we have agreed to add sections to the VC directory for reserved properties. Otherwise, I want to discuss why certain reserved properties have to be on the list. |
@David-Chadwick wrote:
Yes, agreed. There are a few paths that the WG could consider wrt. the issue you raise, @David-Chadwick.
My personal choices would be for (in order of preference) 1, 2, and 3. |
@awoie wrote:
I expect that will be a part of the discussion. I had presumed that no one was pushing back on the concept of "if there is an extension point listed in a normative section of the VCDM, then the equivalent section will be created for that extension point in the VC Specs Directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer to cover only the existing terms that shipped in v1 and v1.1 contexts, and then follow up on "new terms" such as "render", "confirmationMethod", "presentationSchema", etc...
The issue was discussed in a meeting on 2023-04-26
View the transcript2.2. Add first pass at reserved properties table (pr vc-data-model#1097)See github pull request vc-data-model#1097. Manu Sporny: some new PRs were added recently, suggest we deep dive on #1097. Brent Zundel: agree we should, 5-10 minutes (ish), as there are other PRs and work items to look at - this would be time well spent. Manu Sporny: #1100 is potentially important for the group, but I have not had time to review yet. Orie Steele: I'm in favor of getting this into the place where it can be merged. it is doing too much now.
David Chadwick: regarding conformance test, the three already in 1.1 already have conformance tests since the are MUST fields. Manu Sporny: going with Orie's suggestion, the concrete change request is "lets just deal with the things in the spec right now", and then define URLs for that.
David Chadwick: if you are going down to the type level, you are going to cut the group up into small groups, each of which may have implemented. Brent Zundel: it was made clear when drafting the charter that the expectation was any normative statements would have an implementation.
Brent Zundel: the bar needs to be raised for v2. Manu Sporny: +1 to brent, if we don't do something about this we will see formal objections when we try to exit to CR.
David Chadwick: brent said he wants the types to be formally standardized, and this worries me. That will be very difficult.
David Chadwick: standardizing the way to do extensions is the way to go, so people can experiment and some results will be come standards. Manu Sporny: we are not saying you have to formally standardize things at these extension points. Phillip Long: manu just cleared up my concern.
Brent Zundel: responding to DavidC, from my point of view we have a standardized method of extending the datamodel - JSON-LD.
Kristina Yasuda: direction we are going is splitting PR in two as discussed; still need to agree on the bar that is needed to "get back in" to the core DM.
Manu Sporny: question - we said Orie was going to make his changes and wg was going to review... did anyone review? Orie Steele: we didn't make any changes, I sent email about this to the list. We were intending to make changes and met as editors and decided we didn't need to make any changes. |
c50c068
to
3e02ad0
Compare
Based on the discussion yesterday, I have removed the proposed new terms and only included properties that existed in v1.1. Per @OR13's request, I have also asserted the URLs associated with each term as normative statements. This should address almost all of the concerns raised on the call. The only one I'm unsure of is @David-Chadwick, to whom I noted that I'd revise the PR and then re-request his review on these three items. The presumption with this PR is that if it goes through, each section associated with the property would be removed from the specification and an entry would be added at the end of the specification, in the "Revision History" section, noting the removal and pointing to the respective section in the v1.1 specification (so that people can find the v1.1 sections if they wanted to). An alternative would be to link to the v1.1 sections in the table. I could go either way and would like feedback from anyone seeing this comment on what they'd prefer to see in a future PR, when we remove the sections from the spec. |
@awoie can you please re-review? |
a0756eb
to
dd7666c
Compare
I believe this is ready to merge |
Normative, multiple reviews, changes requested and made, no objections, merging. |
This adds a first pass at the reserved properties table (as suggested in PR https://github.com/w3c/vc-data-model/pull/1082/files#r1170186655 by @mprorock).
Preview | Diff