-
Notifications
You must be signed in to change notification settings - Fork 124
Remove outdated v1.0 JWT claim registrations. #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not 100% sure.
Regardless of this PR there seems to be already a slight issue with the current JWT registration: it refers to a dated URL for the vc Rec. Which means that if someone clicks on that URL, he/she is directed to an outdated version of the spec, which is clearly indicated by the ugly red thingy popping up in the face. It is not a bug, but it looks ugly, to say the least. I do not know the IANA/JWT procedures, but it would look better if that was amended.
However... even if that change is done, wouldn't we get into the same situation, eventually, if this PR is accepted? Wouldn't V1 become outdated and, therefore, create similar problems again?
The introductory text in the spec should clearly be changed (it is not a "will be submitted" any more), but it may be cleaner to keep the text in our spec and try to get the IANA to change the reference when the time comes...
This is not a strong objection, so if others are o.k. with the PR, I won't object. But it may be food for thought.
I wouldn't object to keeping it in there, but then the IANA registration will have to be updated (which is fine, there is a process for doing that to the JWT claims registry). The problem w/ keeping that in the vc-data-model is that this spec no longer defines JWT usage, it's the VC-JWT spec that does that, and that spec has deprecated the usage of the "vc" and "vp" properties. Other options include:
Maybe option 2 is the best option? |
@msporny thanks for raising this PR, It think it is the correct approach. I think 2 is probably the way to go. |
Here is a companion PR, that moves them to vc-jwt, and adds a note about asking the IESG to fix the registry: |
Option (2) is probably the cleanest, provided that the JWT registry can be changed easily (I am not familiar with its process) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Substantive (but already processed by IANA), multiple reviews, PR opened on VC-JWT to adopt text until JWT registry is fixed https://github.com/w3c/vc-jose-cose/pull/124/files, no changes requested, no objections, merging. |
This PR removes the outdated v1.0 IANA registrations for "vc" and "vp" (since that happened a while ago and they now exist in the JWT Claims registry here):
https://www.iana.org/assignments/jwt/jwt.xhtml
We don't need to keep these registration requests around, as they've been processed by IANA, and the request exists here (in perpetuity): https://www.w3.org/TR/vc-data-model/#iana-considerations
Preview | Diff