Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that integrity protecting JSON-LD Contexts are allowed. #1537

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

msporny
Copy link
Member

@msporny msporny commented Aug 3, 2024

This PR is a partial fix for an issue raised in w3c/vc-data-integrity#272 by noting that specification authors may require that JSON-LD Contexts are integrity protected by using the relatedResource feature.


Preview | Diff

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is just an editorial thing, take it or leave it.)

The term "specification authors" stopped me for a moment. I looked at the text overall, and this term is usually used making it clear what these people really define (new securing mechanism, etc). But the general term is not defined.

I presume that we are talking here about people authoring a new context file related to their applications. Maybe it is better to say "Specification authors who...", or simply replace the term by "Authors of new context files...".

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding back my suggestions from my other review that happened at the same time as accepting another suggestion.

index.html Outdated
Comment on lines 1286 to 1350
Authors of JSON-LD Contexts MAY require that those context files be integrity
protected by using the `relatedResource` feature described in Section
[[[#integrity-of-related-resources]]] or an equivalent mechanism.
Copy link
Contributor

@dlongley dlongley Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what this is about is ecosystems that want to provide their own special profiling rules (but also look below at the other option):

Suggested change
Authors of JSON-LD Contexts MAY require that those context files be integrity
protected by using the `relatedResource` feature described in Section
[[[#integrity-of-related-resources]]] or an equivalent mechanism.
Profiles of this specification MAY require that JSON-LD Contexts are integrity
protected by using the `relatedResource` feature described in Section
[[[#integrity-of-related-resources]]], or an equivalent mechanism.

Copy link
Contributor

@dlongley dlongley Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, for language that is more verbose but more similar to what is in the controller document:

Suggested change
Authors of JSON-LD Contexts MAY require that those context files be integrity
protected by using the `relatedResource` feature described in Section
[[[#integrity-of-related-resources]]] or an equivalent mechanism.
Other specifications that profile this specification MAY require that JSON-LD
Contexts are integrity protected by using the `relatedResource` feature
described in Section [[[#integrity-of-related-resources]]], or an equivalent
mechanism.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was messing with merge conflicts and had to force push a change, which disconnected your change requests from the PR. Can you make the change suggestions again, please?

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
index.html Outdated Show resolved Hide resolved
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
@msporny
Copy link
Member Author

msporny commented Aug 9, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 7abe96b into main Aug 9, 2024
1 check passed
@msporny msporny deleted the msporny-cip branch August 9, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during CR1 editorial Purely editorial changes to the specification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants