-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note that integrity protecting JSON-LD Contexts are allowed. #1537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This is just an editorial thing, take it or leave it.)
The term "specification authors" stopped me for a moment. I looked at the text overall, and this term is usually used making it clear what these people really define (new securing mechanism, etc). But the general term is not defined.
I presume that we are talking here about people authoring a new context file related to their applications. Maybe it is better to say "Specification authors who...", or simply replace the term by "Authors of new context files...".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding back my suggestions from my other review that happened at the same time as accepting another suggestion.
index.html
Outdated
Authors of JSON-LD Contexts MAY require that those context files be integrity | ||
protected by using the `relatedResource` feature described in Section | ||
[[[#integrity-of-related-resources]]] or an equivalent mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what this is about is ecosystems that want to provide their own special profiling rules (but also look below at the other option):
Authors of JSON-LD Contexts MAY require that those context files be integrity | |
protected by using the `relatedResource` feature described in Section | |
[[[#integrity-of-related-resources]]] or an equivalent mechanism. | |
Profiles of this specification MAY require that JSON-LD Contexts are integrity | |
protected by using the `relatedResource` feature described in Section | |
[[[#integrity-of-related-resources]]], or an equivalent mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, for language that is more verbose but more similar to what is in the controller document:
Authors of JSON-LD Contexts MAY require that those context files be integrity | |
protected by using the `relatedResource` feature described in Section | |
[[[#integrity-of-related-resources]]] or an equivalent mechanism. | |
Other specifications that profile this specification MAY require that JSON-LD | |
Contexts are integrity protected by using the `relatedResource` feature | |
described in Section [[[#integrity-of-related-resources]]], or an equivalent | |
mechanism. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was messing with merge conflicts and had to force push a change, which disconnected your change requests from the PR. Can you make the change suggestions again, please?
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Editorial, multiple reviews, changes requested and made, no objections, merging. |
This PR is a partial fix for an issue raised in w3c/vc-data-integrity#272 by noting that specification authors may require that JSON-LD Contexts are integrity protected by using the
relatedResource
feature.Preview | Diff