Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mis-implementation Issue #54

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Remove mis-implementation Issue #54

merged 1 commit into from
Aug 10, 2023

Conversation

Wind4Greg
Copy link
Contributor

@Wind4Greg Wind4Greg commented Aug 3, 2023 •
edited by pr-preview bot
Loading

This PR removes

Issue 1
There are known mis-implementation attacks against multiple flavors of EdDSA implementations. 
We might want to warn about what to look out for and how to mitigate the attacks.

This is now extensively covered in section 4.1 Security Properties of Ed25519 Implementations and should have been deleted after that text was added.

Preview | Diff

@Wind4Greg
Remove mis-implementation issue.
201bcc9 
This has been incorporated into the main text.
dmitrizagidulin
dmitrizagidulin approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @Wind4Greg !

@msporny
Copy link
Member

msporny commented Aug 10, 2023

Editorial, multiple reviews, no changes requested, no objections, merging.

@msporny msporny merged commit 1121027 into w3c:main Aug 10, 2023
1 check passed
@Wind4Greg Wind4Greg deleted the remove-issue-misimplementation branch December 4, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msporny msporny msporny approved these changes

@dmitrizagidulin dmitrizagidulin dmitrizagidulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wind4Greg @msporny @dmitrizagidulin