Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

[Japanese] Create decision-tree.ja.md #752

Merged
merged 15 commits into from
Mar 5, 2024

Conversation

hiroya-uga
Copy link
Contributor

@hiroya-uga hiroya-uga commented Feb 23, 2024

Copy link

netlify bot commented Feb 23, 2024

Deploy Preview for wai-tutorials2 ready!

Name Link
🔨 Latest commit 31b5b35
🔍 Latest deploy log https://app.netlify.com/sites/wai-tutorials2/deploys/65e6706c139d8c00086476f9
😎 Deploy Preview https://deploy-preview-752--wai-tutorials2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hiroya-uga hiroya-uga force-pushed the feature/ja-decision-tree branch from 9662c72 to 2cd059e Compare February 23, 2024 05:50
Copy link
Contributor Author

@hiroya-uga hiroya-uga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remibetin I have worked on it! Could you please check it?

content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
@hiroya-uga hiroya-uga force-pushed the feature/ja-decision-tree branch 3 times, most recently from 161853d to ec88e34 Compare February 23, 2024 06:08
Copy link
Member

@remibetin remibetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @hiroya-uga for this new translation!

I have added some initial comments for you to consider, with the help of an automatic translation tool.

I will now ask some native Japanese reviewers if they can add their comments. If you know some people that might be willing to help, you can also let me know by email.

content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
@hiroya-uga hiroya-uga force-pushed the feature/ja-decision-tree branch 2 times, most recently from d79ed82 to ef44012 Compare February 27, 2024 01:15
@hiroya-uga
Copy link
Contributor Author

@remibetin

I will now ask some native Japanese reviewers if they can add their comments. If you know some people that might be willing to help, you can also let me know by email.

Yes, I know! I will send you the email!

@hiroya-uga
Copy link
Contributor Author

@remibetin
I would like to introduce @momdo.
He is my friend who are active to translate WHATWG's HTML and other specs of web into Japanese.
https://github.com/momdo/momdo.github.io/wiki

I have confirmed that I can request a review from him.
How about it?

content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
@remibetin
Copy link
Member

@remibetin I would like to introduce @momdo.
I have confirmed that I can request a review from him. How about it?

Sure, @momdo is welcome to participate in the review!

Thank you @momdo! For information on reviewing WAI translations, please read the following documents:

To confirm your intent, please indicate in the Pull Request the date by which you plan to complete the review.

@momdo
Copy link
Contributor

momdo commented Feb 27, 2024

@remibetin @hiroya-uga

Thank you for the invitation.
I intend to complete the review by 5 March.

@hiroya-uga hiroya-uga force-pushed the feature/ja-decision-tree branch from ef44012 to 90363d7 Compare February 28, 2024 01:39
@hiroya-uga hiroya-uga force-pushed the feature/ja-decision-tree branch from 90363d7 to 8769a74 Compare February 29, 2024 01:39
@remibetin remibetin assigned momdo and unassigned hiroya-uga Feb 29, 2024
Copy link
Contributor

@momdo momdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiroya-uga @remibetin
Review completed. Please let me know if you have any questions.

content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
content/images/decision-tree.ja.md Outdated Show resolved Hide resolved
@hiroya-uga
Copy link
Contributor Author

hiroya-uga commented Mar 3, 2024

@momdo cc: @remibetin
Thank you for the review! I have made all the corrections. Could you please review them? :^)

demo: https://deploy-preview-752--wai-tutorials2.netlify.app/tutorials/images/decision-tree/ja
origin: https://www.w3.org/WAI/tutorials/images/decision-tree/

hiroya-uga added a commit to hiroya-uga/wai-tutorials that referenced this pull request Mar 4, 2024
@hiroya-uga hiroya-uga force-pushed the feature/ja-decision-tree branch from 9999b24 to 3159a56 Compare March 4, 2024 14:19
@momdo
Copy link
Contributor

momdo commented Mar 4, 2024

@hiroya-uga
I looked at the demo page and thought, the current heading text is "alt決定木," but does it look good? And when you read it aloud, how does it make you feel?
It's a matter of personal preference, I feel like calling it "altデシジョンツリー" a little bit.

@remibetin
Copy link
Member

@momdo Considering your contribution to the review, I think right to make your name appear as "Contributor" to the translation. Let me know how you would like to see your name written.

@hiroya-uga
Copy link
Contributor Author

I looked at the demo page and thought, the current heading text is "alt決定木," but does it
look good? And when you read it aloud, how does it make you feel?
It's a matter of personal preference, I feel like calling it "altデシジョンツリー" a little bit.

@momdo 決定木 is like 決定キー 🙃
Of course, I wonted to use "ディシジョンツリー".

But I did not know whether it is famous or not...
So, I'm glad for this advice!

I changed to "ディシジョンツリー"!🎉

fyi:

決定木
image

ディシジョンツリー
image

デシジョンツリー
image

@momdo
Copy link
Contributor

momdo commented Mar 4, 2024

@hiroya-uga
Thank you so much. Looks good to me.

@remibetin
I'm grateful for your offer.
I would like to display the following name:
Naoki Nakamura

@hiroya-uga
Copy link
Contributor Author

@momdo Thank you! Would you check approve?

@remibetin I added the name of momdo into contributors! #752 (comment)

@remibetin remibetin self-requested a review March 5, 2024 09:33
@remibetin remibetin assigned shawna-slh and unassigned momdo Mar 5, 2024
@remibetin
Copy link
Member

Thank you @hiroya-uga @momdo for your collaborative work! 🎉

We will publish the translation very soon.

@shawna-slh
Copy link
Contributor

Thank you!

@shawna-slh shawna-slh merged commit d763d65 into w3c:master-2.0 Mar 5, 2024
4 of 7 checks passed
@remibetin
Copy link
Member

This translation has been published today 🚀 Thank you @hiroya-uga @momdo!

See https://www.w3.org/WAI/tutorials/images/decision-tree/ja

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Japanese] An alt Decision Tree
4 participants