Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F87 - removing the with-AT clauses #473

Merged
merged 9 commits into from
Sep 26, 2018
Merged

F87 - removing the with-AT clauses #473

merged 9 commits into from
Sep 26, 2018

Conversation

alastc
Copy link
Contributor

@alastc alastc commented Sep 11, 2018

For issue #433

@alastc alastc changed the title Removing with AT clauses F87 - removing the with-AT clauses Sep 11, 2018
@@ -1,7 +1,7 @@
<!DOCTYPE html><html lang="en" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml"><head><title>Failure of Success Criterion 1.3.1 due to inserting non-decorative content by using :before and :after pseudo-elements and the 'content' property in CSS</title><link rel="stylesheet" type="text/css" href="../../css/sources.css" class="remove"></link></head><body><h1>Failure of Success Criterion 1.3.1 due to inserting non-decorative content by using :before and :after pseudo-elements and the 'content' property in CSS</h1><section class="meta"><p class="id">ID: F87</p><p class="technology">Technology: failures</p><p class="type">Type: Failure</p></section><section id="applicability"><h2>When to Use</h2>
<p>All technologies that support CSS.</p>
</section><section id="description"><h2>Description</h2>
<p>The CSS :before and :after pseudo-elements specify the location of content before and after an element's document tree content. The content property, in conjunction with these pseudo-elements, specifies what is inserted. For users who need to customize or turn off style information in order to view content according to their needs, assistive technologies may not be able to access the information that is inserted using CSS. Therefore, it is a failure to use these properties to insert non-decorative content.</p>
<p>The CSS :before and :after pseudo-elements specify the location of content before and after an element's document tree content. The content property, in conjunction with these pseudo-elements, specifies what is inserted. For users who need to customize or turn off style information in order to view content according to their needs, they may not be able to access the information that is inserted using CSS. Therefore, it is a failure to use these properties to insert non-decorative content.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wary of adding "or turn off" since in WCAG you can rely on a technology like CSS or Javascript and requiring support for users turning off styles isn't mandated. I think that if we strike the "or turn off" phrase we will be ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That phrase was there already, I just removed the "assistive technologies may not be able to access the information" bit as that is not true anymore.

@@ -45,7 +45,7 @@
<ol>
<li>Examine all content inserted through use of the :before and :after pseudo-elements and the content property</li>
<li>Verify that the content is decorative.</li>
<li>If the inserted content is not decorative, check that the information is provided to assistive technologies and is also available when CSS is turned off.</li>
<li>If the inserted content is not decorative, check that the information is available when the :before and :after styles are overriden, or when CSS is turned off.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how this evolves. What if the browsers allow stacking of styles so the "jim:" that precedes a line in the can also have a paragraph symbol or series of dots to indicate a heading if the user wants that? Would the "or when CSS is turned off" still make sense? I get that today the turning off of CSS is the easy substitute for the actual test, but am not sure if it is the right thing to do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS overrides are fairly course by necessity, unless you create super-specific, site-only styles then you either over-ride it or not.
I don't see a wide-use scenario where you would have multiple pseudo elements with content, so I can't see how that would be supported. (You would have extra real, DOM elements instead.)

@mraccess77
Copy link

I'm ok with the change although I agree it's a nebulous area.

@detlevhfischer
Copy link
Contributor

"overriden" should probably be "overridden"
In the light of good(?) SR support of CSS-generated content I am a bit wary of this as a general failure. Are there actual use cases where LV users completely replace author's styles (not just beef up particular elements) and thereby prevent CSS-generated content form working? I have personally so far not come across a user doing that (I would imagine many other things would just break so it seems not a workable approach for most common sites) - but I am ready to support this if there is enough evidence that thisis a real use case.

@awkawk awkawk merged commit bc288ee into master Sep 26, 2018
@awkawk
Copy link
Member

awkawk commented Sep 26, 2018

@awkawk awkawk deleted the update-F87 branch September 26, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants