Skip to content

Conversation

azaroth42
Copy link
Collaborator

No description provided.

@iherman
Copy link
Member

iherman commented Nov 13, 2016

Great. @azaroth42, some minor issues before merging:

  • The vocab document still has an open issue listed in the status section. Isn't it possible to remove that, too? Wasn't that an "at risk" feature that has been removed?
  • It may be worth emphasizing in the changes' section that some feature were removed because they were at risk, and some were removed because they did not get through the original exit criteria. Just to be "elegant":-)
  • Before merging, can you make a copy of the files in the /TR directory in admin? That is the reference we would use for the checker and the CR transition request...

Thanks!

@iherman
Copy link
Member

iherman commented Nov 13, 2016

@azaroth42 @tcole3 :

I have prepared two drafts for the transition mailings as part of this PR:

  • admin/CRTransitionAdmin/3rd CRTransitionRequest.md
  • admin/CRTransitionAdmin/3rd PublicationRequest.md

I have already sent a question to the director whether a simplified transition (see the first mail) is enough for this case; I hope it is. Please review it and change any details that you see fit.

The mail should go out on Monday 14th. @azaroth42 if the files do not pass pubrules' checker on that day, that is fine, it can be done on, say, Tuesday; the content should be final, though.

The AS terms remain at risk for now...
ie, the fact that the Composite et al were at risk in the earlier versions.
- An old fragment ID was referred to in the list of JSON terms
@iherman
Copy link
Member

iherman commented Nov 14, 2016

@azaroth42 : I took care of my own comments. (I realized that the at-risk in the vocab is related to the the AS vocabulary, so it remains as is for now.) I have also checked the files with pubrules' checker and the link checker, and took care of a link error.

Will merge now.

@iherman iherman merged commit 929c823 into gh-pages Nov 14, 2016
@iherman iherman deleted the cr2-revisions branch November 22, 2016 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants