Add sub-record example and fix idl #334

kenchris · 2019-09-03T13:32:37Z

(Support for custom sub-record types will be added soon)

zolkis · 2019-09-03T13:36:25Z

index.html

+        newline separators).
+      </p>
+      <p>
+        This example shows how to read an exernal record for social posts,


typo: external

zolkis · 2019-09-03T13:39:46Z

index.html

@@ -909,6 +909,85 @@ <h4>
 setTimeout(() => controller.abort(), 3000);
    </pre>
  </aside>
+
+  <aside title="Read a external record with sub-records" class="example">
+      <p>


I contest the usefulness of this vs the added complexity.
If storage efficiency is of concern, an external type with binary (e.g. CBOR) would be a yet more efficient solution, without the arbitrary conventions made down this example.

It is supported by NDEF and even used in standard records like smart poster.

You can of course contest using NDEF at all (and write data directly to the tag using the type specific protocols), but hey that is what we are spec'ing.

If I am reading correctly the NFC Forum Smart Poster spec, there is no word about "sub-record", only about records (of type Title, URI, Action, Icon, Size, Type). The term "sub-record" seems to be made up outside of NFC Forum, so it's an application level term from NFC point of view. Read my previous comment in that context: apps could as well choose a more efficient storage method inside the allowed NDEF records. If we expose an app-level mechanism on top of NDEF in the Web NFC spec that needs to go though the usual feature addition path: use case, issue, group discussion, PR.

OK, it definitely embeds the records and that is also defined how to do in other NFC specs. Whether we call them sub records or embedded records, I don't care.

zolkis · 2019-09-03T13:48:49Z

index.html

@@ -909,6 +909,85 @@ <h4>
 setTimeout(() => controller.abort(), 3000);
    </pre>
  </aside>
+
+  <aside title="Read a external record with sub-records" class="example">


This CL adds support for reading sub records of a NDEFRecord, i.e. NDEFRecord#toRecords(). Note: No support for writing yet. The spec changes: w3c/web-nfc#333 w3c/web-nfc#334 w3c/web-nfc#359 BUG=520391 Change-Id: Ic7ac74416afa8e43f5293e4ca85e538fc700f3c6

This CL adds support for reading sub records of a NDEFRecord, i.e. NDEFRecord#toRecords(). Note: No support for writing yet. The spec changes: w3c/web-nfc#333 w3c/web-nfc#334 w3c/web-nfc#359 BUG=520391 Change-Id: Ic7ac74416afa8e43f5293e4ca85e538fc700f3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824395 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#712452}

…estonly Automatic update from web-platform-tests [webnfc] toRecords() implementation This CL adds support for reading sub records of a NDEFRecord, i.e. NDEFRecord#toRecords(). Note: No support for writing yet. The spec changes: w3c/web-nfc#333 w3c/web-nfc#334 w3c/web-nfc#359 BUG=520391 Change-Id: Ic7ac74416afa8e43f5293e4ca85e538fc700f3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824395 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#712452} -- wpt-commits: 456845e6c6031335bc2e9e0d37323310e6dac2c3 wpt-pr: 19881

…estonly Automatic update from web-platform-tests [webnfc] toRecords() implementation This CL adds support for reading sub records of a NDEFRecord, i.e. NDEFRecord#toRecords(). Note: No support for writing yet. The spec changes: w3c/web-nfc#333 w3c/web-nfc#334 w3c/web-nfc#359 BUG=520391 Change-Id: Ic7ac74416afa8e43f5293e4ca85e538fc700f3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824395 Commit-Queue: Leon Han <leon.hanintel.com> Reviewed-by: Daniel Cheng <dchengchromium.org> Reviewed-by: Reilly Grant <reillygchromium.org> Cr-Commit-Position: refs/heads/master{#712452} -- wpt-commits: 456845e6c6031335bc2e9e0d37323310e6dac2c3 wpt-pr: 19881 UltraBlame original commit: 1a9531f50510465f418a5ddb3756c341b44f95d6

Add sub-record example and fix idl

e1fef8f

kenchris merged commit 40d7c8c into w3c:gh-pages Sep 3, 2019

zolkis reviewed Sep 3, 2019

View reviewed changes

index.html

newline separators).

</p>

<p>

This example shows how to read an exernal record for social posts,

Copy link

Contributor

zolkis Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: external

zolkis reviewed Sep 3, 2019

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Oct 25, 2019

[webnfc] toRecords() implementation web-platform-tests/wpt#19881

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sub-record example and fix idl #334

Add sub-record example and fix idl #334

kenchris commented Sep 3, 2019 •

edited by pr-preview bot

Loading

zolkis Sep 3, 2019

zolkis Sep 3, 2019

kenchris Sep 3, 2019

zolkis Sep 3, 2019

kenchris Sep 3, 2019

zolkis Sep 3, 2019

kenchris Sep 3, 2019

Add sub-record example and fix idl #334

Add sub-record example and fix idl #334

Conversation

kenchris commented Sep 3, 2019 • edited by pr-preview bot Loading

zolkis Sep 3, 2019

Choose a reason for hiding this comment

zolkis Sep 3, 2019

Choose a reason for hiding this comment

kenchris Sep 3, 2019

Choose a reason for hiding this comment

zolkis Sep 3, 2019

Choose a reason for hiding this comment

kenchris Sep 3, 2019

Choose a reason for hiding this comment

zolkis Sep 3, 2019

Choose a reason for hiding this comment

kenchris Sep 3, 2019

Choose a reason for hiding this comment

kenchris commented Sep 3, 2019 •

edited by pr-preview bot

Loading