Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Security section to the end. Fix HTML errors. #436

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

zolkis
Copy link
Contributor

@zolkis zolkis commented Nov 5, 2019

To editors: please take attention to close tags. Browsers do complete them, but tools will complain.
Also, no flow content inside <p>.
Will continue with the Security section in a subsequent PR, this is to have a corrected baseline.
Signed-off-by: Zoltan Kis zoltan.kis@intel.com


Preview | Diff


<section> <h3>Chain of trust</h3>
<p>
Web pages using Web NFC are not trusted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considered trusted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content of Security section will be updated in a future PR.

Web pages using Web NFC are not trusted.
This means that the user needs to be aware of exactly what a web page is
intending to do with NFC at any given moment. Implementations need to
make sure that when the user authorizes a method of this API, then only that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'authorizes a method of this API' sounds cryptic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

</section>
<section> <h4>Restrict automatic handling</h4>
<p>
The payload data on <a>NFC content</a> is untrusted, and must not be used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But people can use signature records to make it trusted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a malicious third party could delete the signature record from the NDEF message or
attach a new signature record to prevent the user from noticing any malicious change of content.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But with the right policies in place it should be indeed fine (trusted).
Anyway, content changes come in a next PR.

@beaufortfrancois
Copy link
Collaborator

Can you split this CL in two CLs so that it's easier to review?

@zolkis
Copy link
Contributor Author

zolkis commented Nov 6, 2019

There is no content change yet, just moved the Security section to the end, added missing closing tags and changed <p> tags that contained flow content.

Purely syntactic changes, in that sense, this is the split, before I make content changes.

@beaufortfrancois
Copy link
Collaborator

I was confused as @kenchris was suggesting changes.
Did you run a tool to make sure all html tags were closed?

Signed-off-by: Zoltan Kis <zoltan.kis@intel.com>
@zolkis
Copy link
Contributor Author

zolkis commented Nov 6, 2019

Did you run a tool to make sure all html tags were closed?

Good idea. I've run tidy and fixed a few more errors.

Copy link
Collaborator

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenchris kenchris merged commit 6b0cdb8 into w3c:gh-pages Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants