"SCHEME_DOMAIN_PORT is not defined" failures due to HTTP 500 all over websockets/

[foolip]

As found in #1695 (comment), lots of tsets under websockets/ are failing. For example:
https://wpt.fyi/websockets/binary

In Chrome devtools I see "Failed to load resource: the server responded with a status of 500 (Internal Server Error)" so something pretty odd is happening here.

[foolip]

@jugglinmike, not sure if this will come up in your investigation, but a widespread failure like this is pretty easy to justify the time spending to fix...

[zcorpan]

I'm assuming that a 500 can happen if there's no port defined for wss. constants.js contains:

var PORT_SSL = "{{ports[wss][0]}}";

https://wptserve.readthedocs.io/en/latest/pipes.html#sub

[zcorpan]

config.default.json (read by tools/wptserve/wptserve/config.py) has:

 "ports":{"http":[8000, "auto"],
          "https":[8443],
          "ws":["auto"],
          "wss":["auto"]},

I don't know what isn't working, though...

[gsnedders]

Labelling this as roadmap and not urgent on the assumption that this has been broken a while.

[gsnedders]

 0:37.96 WARNING list index out of range
Traceback (most recent call last):
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/server.py", line 256, in handle_one_request
    handler(request, response)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/handlers.py", line 151, in __call__
    response = wrap_pipeline(path, request, response)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/handlers.py", line 117, in wrap_pipeline
    response = pipeline(request, response)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 34, in __call__
    response = func(request, response, *args)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 127, in inner
    return f(request, response, *arg_values)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 363, in sub
    new_content = template(request, content, escape_type=escape_type)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 440, in template
    new_content = template_regexp.sub(config_replacement, content)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 425, in config_replacement
    value = value[item[1]]
IndexError: list index out of range

 0:37.99 WARNING list index out of range
Traceback (most recent call last):
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/server.py", line 256, in handle_one_request
    handler(request, response)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/handlers.py", line 151, in __call__
    response = wrap_pipeline(path, request, response)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/handlers.py", line 117, in wrap_pipeline
    response = pipeline(request, response)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 34, in __call__
    response = func(request, response, *args)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 127, in inner
    return f(request, response, *arg_values)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 363, in sub
    new_content = template(request, content, escape_type=escape_type)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 440, in template
    new_content = template_regexp.sub(config_replacement, content)
  File "/Users/gsnedders/Documents/other-projects/wpt/web-platform-tests/tools/wptserve/wptserve/pipes.py", line 425, in config_replacement
    value = value[item[1]]
IndexError: list index out of range

[gsnedders]

More breakage from bfef1f2 (#10231) it would seem.

[gsnedders]

So not broken for so long, and my fault…

[gsnedders]

@zcorpan constants.js seems to be fine.

[gsnedders]

OK, so it is /websockets/constants.js?pipe=sub that is failing with 500 (which makes sense in the case of 001.html). This is wptrunner specific, seemingly, so presumably our override config is broken.

[gsnedders]

The bug here is:

        config.ports = {
            "http": [8000, 8001],
            "https": [8443],
            "ws": [8888]
        }

in environment.py.

[jgraham]

I need to fix this to unbreak a gecko sync, so there will be a patch soon.

[alijuma]

Pinging for an update since this is marked Priority:urgent.

[foolip]

Assigning to @jgraham as the urgency is on part of Gecko sync.

[gsnedders]

I reviewed a patch last week by @jgraham. Should we not fix it upstream soon, even if the Gecko sync doesn't land?

[gsnedders]

fixed in #10557 (which sadly didn't link here)