Rename quirks-mode to quirks to match the standard shortname #8895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/quirks#20. `grep -r quirks-mode *` yielded nothing so nothing external relies on this being here it appears.
|
There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
Build PASSEDStarted: 2018-01-04 10:06:19 Failing Jobs
View more information about this build on: |
jdm
approved these changes
Jan 4, 2018
foolip
added a commit
that referenced
this pull request
Jan 5, 2018
Like #8895 for quirks, this adapts to whatwg/xhr#184, after which the wpt links are generated and match the shortname. https://xhr.spec.whatwg.org/ currently has a 404 link to https://github.com/w3c/web-platform-tests/tree/master/xhr.
foolip
added a commit
to foolip/day-to-day
that referenced
this pull request
Jan 5, 2018
Renamed in web-platform-tests: web-platform-tests/wpt#8895 web-platform-tests/wpt#8937
foolip
added a commit
that referenced
this pull request
Jan 6, 2018
Like #8895 for quirks, this adapts to whatwg/xhr#184, after which the wpt links are generated and match the shortname. https://xhr.spec.whatwg.org/ currently has a 404 link to https://github.com/w3c/web-platform-tests/tree/master/xhr. Steps taken: * rename the directory * sed 's#/XMLHttpRequest#/xhr#g' everywhere * manually handle a few remaining cases of "XMLHttpRequest/" * look at ouput of grep -E '\SXMLHttpRequest' and 'XMLHttpRequest[^(;]'
zcorpan
added a commit
to whatwg/quirks
that referenced
this pull request
Jan 8, 2018
These were 404s since web-platform-tests/wpt#8895
zcorpan
added a commit
to whatwg/quirks
that referenced
this pull request
Jan 8, 2018
These were 404s since web-platform-tests/wpt#8895
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 16, 2018
external/wpt/FileAPI/BlobURL/test1-manual.html and external/wpt/FileAPI/BlobURL/test3-manual.html were removed in web-platform-tests/wpt#8612 external/wpt/quirks-mode/active-and-hover-manual.html was renamed in web-platform-tests/wpt#8895, and the new name is now in NeverFixTests. Change-Id: I04804bfc5f9a3d37b44e5bc0f45308e6fe8bd639 Reviewed-on: https://chromium-review.googlesource.com/966289 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#543700}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/quirks#20.
grep -r quirks-mode *yielded nothing so nothing external relies on this being here it appears.