-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize JSON by reference to Infra spec #465
Serialize JSON by reference to Infra spec #465
Conversation
You will also need to change
to be an Infra map or some such. (And you need to run |
To Anne's point, I think that the example https://infra.spec.whatwg.org/#example-map-notation is basically what we'd want to copy/paste into that step. |
Thanks, yep — will update the patch with that addition |
OK, changed to that. |
a2ff90f
to
9c41baa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
index.src.html
Outdated
|
||
4. Let |object| be a new JavaScript object with properties initialized as | ||
4. Let |object| be a <a lt="ordered map">map</span> with a single key initialized as | ||
follows: | ||
|
||
: "`csp-report`" | ||
:: |body| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the perfect opportunity to use
Let object be «[ "
csp-report
" → body ]»
I suggest we go for it. (Or even inline that into the next step.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the perfect opportunity to use
Let object be «[ "csp-report" → body ]»
I suggest we go for it. (Or even inline that into the next step.)
OK, thanks — I went all the way and inlined it. I like it. One less step. But if it’s too far and we think it’d be more clear to do the |object|-indirection thing, I’m happy to do it that way instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to start normalizing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some weird formatting when looking at the preview. I guess validation might not be CI-checked either...
oops — thanks for catching that
Right. But I can add it to the GitHub Actions workflow, after we get the initial deploy part landed |
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
388fb98
to
47c5dee
Compare
…thored-by: Anne van Kesteren <annevk@annevk.nl> SHA: 78d0908 Reason: push, by @sideshowbarker Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Fixes #455
Preview | Diff