Refactor "get a known element" and "get a known shadow root" #1712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #1707 the browsing context check for an element or shadow root is done after the staleness check. Hereby a staleness check wouldn't be necessary at all if we know that the element's associated browsing context is not the currently selected one. Means moving the content of step 3.1 into step 2 would simplify those two independent checks.
https://w3c.github.io/webdriver/#dfn-get-a-known-element
Example: An element reference from a frame will never be a valid reference within the top-level frame, as such the staleness check will always be false.
Preview | Diff