Add deserialization steps for web frame and web window #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
changed the title
whimboo
force-pushed
the
windor_frame_deserialize
branch
from
82120f6
to
e67c34c
Compare
gsnedders
approved these changes
May 16, 2023
whimboo
force-pushed
the
windor_frame_deserialize
branch
from
e67c34c
to
f60f414
Compare
|
@jgraham mind reviewing as well? Thanks. |
|
@mathiasbynens could someone from Google review this addition as well? I'm not sure who to tag given that @sadym-chromium is out at the moment. |
mathiasbynens
approved these changes
Aug 7, 2023
whimboo
force-pushed
the
windor_frame_deserialize
branch
from
f60f414
to
7acbf75
Compare
jgraham
previously requested changes
Aug 7, 2023
whimboo
force-pushed
the
windor_frame_deserialize
branch
from
7acbf75
to
3775811
Compare
|
@jgraham fixes for both of your comments have been pushed. |
mathiasbynens
approved these changes
Aug 7, 2023
|
@jgraham merging this PR is blocked on your review comments. Can you please re-check if you have the time? Thanks. |
Given that the review comments from James have been addressed, maybe @juliandescottes or @lutien can have a final look at the review? |
lutien
approved these changes
Oct 17, 2023
whimboo
dismissed
jgraham’s stale review
Review comments have been addressed and Sasha re-reviewed
|
Please note that tests will be added as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1274251. |
github-actions bot
added a commit
that referenced
this pull request
Oct 17, 2023
SHA: ea8ff97 Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to xjc90s/webdriver
that referenced
this pull request
Oct 17, 2023
SHA: ea8ff97 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to soloinovator/webdriver
that referenced
this pull request
Oct 17, 2023
SHA: ea8ff97 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to ZRDKPoWeR/webdriver
that referenced
this pull request
Oct 21, 2023
SHA: ea8ff97 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing the serialization of window and frame objects I noticed that there are no deserialization steps available for these two object types.
Preview | Diff