Add "freeze patch" mechanism, add one for filter-effects-1 #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a new way to curate the results of a crawl: a freeze patch allows to freeze the results of a crawl to a specific commit ID in Webref. This is meant for specs that are temporarily broken beyond repair. First such patch is for the filter-effects-1 spec. Each freeze patch is implemented as a JSON file named after the spec's shortname and that contains the commit ID and a `pending` key that links to the issue that tracks the problem in some GitHub repository. The `clean-patches` script proposes to drop the patch when the issue gets closed.
dontcallmedom
approved these changes
Mar 24, 2025
This generalizes the logic that parses property values of a crawn index to gather extract files, and applies it throughout. This actually fixes the `removeFromCuration` logic that was broken for CDDL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new way to curate the results of a crawl: a freeze patch allows to freeze the results of a crawl to a specific commit ID in Webref. This is meant for specs that are temporarily broken beyond repair.
First such patch is for the filter-effects-1 spec.
Each freeze patch is implemented as a JSON file named after the spec's shortname and that contains the commit ID and a
pendingkey that links to the issue that tracks the problem in some GitHub repository. Theclean-patchesscript proposes to drop the patch when the issue gets closed.