Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTCIceCandidateInit members are linked instead of RTCIceCandidate attributes #2916

Closed
sam-vi opened this issue Dec 20, 2023 · 0 comments · Fixed by #2917
Closed

RTCIceCandidateInit members are linked instead of RTCIceCandidate attributes #2916

sam-vi opened this issue Dec 20, 2023 · 0 comments · Fixed by #2917

Comments

@sam-vi
Copy link
Contributor

sam-vi commented Dec 20, 2023

In the RTCIceCandidate interface section, members of the Init dictionary are linked even though the sentence talks about how the attributes of RTCIceCandidate interface are derived.

Other than candidate, sdpMid, sdpMLineIndex, and usernameFragment, the remaining attributes are derived from parsing the candidate member in candidateInitDict, if it is well formed.

This should probably be changed to link to the RTCIceCandidate attributes of the same name instead.
sam-vi added a commit to sam-vi/webrtc-pc that referenced this issue Dec 20, 2023
@sam-vi
Fix references to RTCIceCandidate attributes.
91661ba 
Fixes: w3c#2916.

The containing sentence talks about the derivation of the attributes of RTCIceCandidate, and so it should link to the attibutes of RTCIceCandidate and not to the members of RTCIceCandidateInit.
@sam-vi sam-vi mentioned this issue Dec 20, 2023
Merged
dontcallmedom pushed a commit that referenced this issue Feb 26, 2024
@sam-vi @dontcallmedom
Fix references to RTCIceCandidate attributes.
4934e29 
Fixes: #2916.

The containing sentence talks about the derivation of the attributes of RTCIceCandidate, and so it should link to the attibutes of RTCIceCandidate and not to the members of RTCIceCandidateInit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix references to RTCIceCandidate attributes. sam-vi/webrtc-pc
1 participant
@sam-vi