Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to RTCIceCandidate attributes. #2917

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

sam-vi
Copy link
Contributor

@sam-vi sam-vi commented Dec 20, 2023

Fixes: #2916.

The containing sentence talks about the derivation of the attributes of RTCIceCandidate, and so it should link to the attibutes of RTCIceCandidate and not to the members of RTCIceCandidateInit.


Preview | Diff

Fixes: w3c#2916.

The containing sentence talks about the derivation of the attributes of RTCIceCandidate, and so it should link to the attibutes of RTCIceCandidate and not to the members of RTCIceCandidateInit.
@alvestrand
Copy link
Contributor

Marked as editorial.
Reading the context, I wonder if the paragraph should be deleted instead. When a candidate is created using the constructor, all the attributes seem to be derived from the corresponding members of RTCIceCandidateInit - the ones that are noted in this list are just subject to some extra tests.

@henbos henbos merged commit 4f7d5a3 into w3c:main Dec 21, 2023
3 of 4 checks passed
@sam-vi sam-vi deleted the samvi-candidate-attributes branch April 18, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTCIceCandidateInit members are linked instead of RTCIceCandidate attributes
3 participants