Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the "closing" event to datachannel #2223

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Add the "closing" event to datachannel #2223

merged 1 commit into from
Jul 18, 2019

Conversation

alvestrand
Copy link
Contributor

@alvestrand alvestrand commented Jul 8, 2019 •
edited by pr-preview bot
Loading

As per October 2018 TPAC decision.
Fixes #1827

Preview | Diff

@alvestrand
Add the "closing" event to datachannel
8e9cb19 
As per October 2018 TPAC decision.
Fixes #1827
lgrahl
lgrahl approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@lgrahl lgrahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (People will raise their eyebrows on that one but what can we do 🤷‍♀️.)

@aboba aboba added the Needs Test Needs a WPT test label Jul 18, 2019
@aboba aboba merged commit 36d813f into master Jul 18, 2019
@jan-ivar jan-ivar deleted the datachannel-onclosing-bug-1827 branch August 8, 2019 14:41
@dontcallmedom
Copy link
Member

tested in https://github.com/web-platform-tests/wpt/blob/master/webrtc/RTCDataChannel-send.html removing "needs test" label

@dontcallmedom dontcallmedom removed the Needs Test Needs a WPT test label Dec 18, 2019
@foolip
Copy link
Member

foolip commented Jan 10, 2020

I've filed https://bugs.webkit.org/show_bug.cgi?id=206056 for this.

@jan-ivar do you have a Gecko bug filed already?

Tests are coming in web-platform-tests/wpt#21117, https://github.com/web-platform-tests/wpt/blob/master/webrtc/RTCDataChannel-send.html doesn't currently test this.

@jan-ivar
Copy link
Member

@foolip Looks like bots created one https://bugzilla.mozilla.org/show_bug.cgi?id=1608212 🙂

@foolip
Copy link
Member

foolip commented Jan 16, 2020

@jan-ivar I think that bug is just for importing the change and will be automatically closed. But @jgraham can say for sure how this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboba aboba aboba approved these changes

@lgrahl lgrahl lgrahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTCDataChannel.send during 'closing' state
6 participants
@alvestrand @dontcallmedom @foolip @jan-ivar @aboba @lgrahl