Don't extend TextTrack with WebVTT-specific attributes #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://www.w3.org/Bugs/Public/show_bug.cgi?id=24380 There are still uses of the region identifier concept to clean up, in the parser and in getRegionById().
https://www.w3.org/Bugs/Public/show_bug.cgi?id=24380 With a direct association between cues and regions, the text track itself doesn't need to know about regions, simplifying the API.
|
The parser still needs some work in order to use an id-to-region map instead of a list of regions, but I think this package is big enough and that can wait until we move regions out of the header. |
silviapfeiffer
added a commit
that referenced
this pull request
Jan 30, 2014
Don't extend TextTrack with WebVTT-specific attributes
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Feb 9, 2017
Removed from the spec by w3c/webvtt#31 BUG=690014 Review-Url: https://codereview.chromium.org/2684993003 Cr-Commit-Position: refs/heads/master@{#449140}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Feb 11, 2017
Removed from the WebVTT spec w3c/webvtt#31 Because we no longer need to track a list of regions in TextTrack, we can also remove all the plumbing between the parser and the (loadable) TextTrack. BUG=690014 Review-Url: https://codereview.chromium.org/2685943004 Cr-Commit-Position: refs/heads/master@{#449791}
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 23, 2017
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 23, 2017
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 15, 2017
zcorpan
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Aug 28, 2017
rachelandrew
pushed a commit
to rachelandrew/web-platform-tests
that referenced
this pull request
Nov 8, 2017
webkit-commit-queue
pushed a commit
to cola119/WebKit
that referenced
this pull request
Sep 6, 2023
https://bugs.webkit.org/show_bug.cgi?id=260767 Reviewed by Eric Carlson and Chris Dumez. These APIs were removed from the spec by w3c/webvtt#31 * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/historical-expected.txt: * LayoutTests/media/track/regions-webvtt/vtt-region-list-expected.txt: Removed. * LayoutTests/media/track/regions-webvtt/vtt-region-list.html: Removed. * Source/WebCore/html/track/TextTrack.cpp: (WebCore::TextTrack::addRegion): Deleted. (WebCore::TextTrack::removeRegion): Deleted. * Source/WebCore/html/track/TextTrack.h: * Source/WebCore/html/track/TextTrack.idl: Canonical link: https://commits.webkit.org/267694@main
webkit-commit-queue
pushed a commit
to Ahmad-S792/WebKit
that referenced
this pull request
Feb 18, 2024
https://bugs.webkit.org/show_bug.cgi?id=269649 Reviewed by Eric Carlson. This patch is to align WebKit with Blink / Chromium, Gecko / Firefox and Web Specification [1]: [1] https://w3c.github.io/webvtt/#the-vttregion-interface It was removed from the web-spec in following: W3C Bug - https://www.w3.org/Bugs/Public/show_bug.cgi?id=24380 WebVTT GitHub Commit - w3c/webvtt#31 * Source/WebCore/html/track/VTTRegion.cpp: (VTTRegion::setTrack): * Source/WebCore/html/track/VTTRegion.h: * Source/WebCore/html/track/VTTRegion.idl: * Source/WebCore/html/track/InbandGenericTextTrack.cpp: (InbandGenericTextTrack::newRegionsParsed): * Source/WebCore/html/track/InbandWebVTTTextTrack.cpp: (InbandWebVTTTextTrack::newRegionsParsed): * Source/WebCore/html/track/LoadableTextTrack.cpp: (LoadableTextTrack::newRegionsAvailable): * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/historical-expected.txt: Rebaselined * LayoutTests/media/track/regions-webvtt/vtt-region-constructor.html: Removed in favor of WPT Test: `webvtt/api/VTTRegion/constructor.html` * LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt: Deleted Test Expectations Canonical link: https://commits.webkit.org/274936@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.