Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normative: Updates to region identifier, CSS selection & existance. #349

Merged
merged 2 commits into from
Jun 26, 2017

Conversation

silviapfeiffer
Copy link
Member

  • Make sure regions only get created when they have an identifier
  • introduce a ::cue-region(selector) pseudo-element

Addresses https://www.w3.org/Bugs/Public/show_bug.cgi?id=28471 and https://www.w3.org/Bugs/Public/show_bug.cgi?id=28474

Closes #314

* Make sure regions only get created when they have an identifier
* introduce a ::cue-region(selector) pseudo-element
@silviapfeiffer
Copy link
Member Author

Marked as non-substantive for IPR from ash-nazg.

Copy link
Contributor

@BenjaminSchaaf BenjaminSchaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwsinger
Copy link

LGTM

@plehegar plehegar merged commit 972af2b into w3c:gh-pages Jun 26, 2017
@plehegar
Copy link
Member

Landed following @silviapfeiffer recommendation.

@silviapfeiffer
Copy link
Member Author

Thanks, we'll get Simon's review when he's back. Onto preparing a new WD!

@nigelmegitt
Copy link
Contributor

Guys, I see in #349 (comment) that this was marked as non-substantive for IPR, but in my reading it is definitely substantive. I think telling ash-nazg that the change is non-substantive is not the right approach in these cases. Rather there should be an alternative option to say "it is substantive and as the author I'm granting IPR as required for a W3C Rec track document".

@silviapfeiffer @dwsinger @plehegar perhaps you already agreed the IPR issues offline? I can't see it in the issue.

@dwsinger
Copy link

Hi Nigel. I think this was the author's opinion; I am not sure whether I agree with you or them, but happily CSIRO is a member of the CG at the very least; and the idea and the substance of it were developed in the mailing lists (and notably with the editor, who's away on vacation, which is why Silvia volunteered to write it). I think we're as well covered as we can be; we're effectively responding to comment from the CSS WG and following their suggestions here, which is what wide review is supposed to achieve.

@nigelmegitt
Copy link
Contributor

For IPR stuff CG membership is not relevant - it has to be WG membership or an explicit release. I don't think it being our resolution to a CSS WG comment or a construction based on their suggestions constitutes a release but happy to be educated if not! I suppose it depends on how detailed the wide review comment was, and if that commenter was also a member of TTWG.

@dwsinger
Copy link

dwsinger commented Jun 27, 2017 via email

@nigelmegitt
Copy link
Contributor

For IPR stuff CG membership is not relevant
Sure it is. All members of the CG have signed a Contributor License Agreement, so if you’re worried about the Contributor, that’s covered.

Really? I don't think this does the same thing as the WG membership licensing obligation - unless there's been an explicit agreement made with all the CG members. The IPR policy FAQ is clear that CG members have no licensing obligations.

The commenter was, IIRC, the CSS WG. The resolution was developed in dialog.

This falls squarely under the Patent Policy FAQ on handling contributions from non-participants which says:

When a contribution is being considered for actual inclusion in a document intended to become a Recommendation, the Chair should ask the Contributor to disclose any essential claims, and if there are any, the terms under which those claims would be licensed. Lack of a response to this request is a red flag.

If I understand ash-nazg correctly, it is designed to catch instances where this may be needed: marking the pull request as non-substantive is bypassing that. My concern is that we may end up in an indeterminate state with respect to licensing obligations.

@dwsinger
Copy link

dwsinger commented Jun 27, 2017 via email

@nigelmegitt
Copy link
Contributor

To join a CG, one must sign the Contributor License Agreement.

This is the Community CLA. I see that it includes:

9.2.1. Licensing Obligations to Resulting Specification. If I do not join the Corresponding Working Group, I agree to offer patent licenses according to the W3C Royalty-Free licensing requirements described in Section 5 of the W3C Patent Policy for my Contributions included in the resulting Recommendation. [snip]

which is probably the important bit here.

as a CG member, they made the licensing commitment on joining the CG.

Ah, again this is something that the FAQs haven't been updated to cover. In fact they give the impression that membership of one group doesn't cover any other group. In this case I think the CLA you referenced above probably does cover it for the TTWG too, so I consider myself partially re-educated!

We could mark it s substantive, and say that we’ve done what’s needed (we have an RF licensing commitment from both Silvia’s and Simon’s orgs).

Simon is a member of the WG so is already covered, no problem. It would make sense to mark it as substantive and identify the RF licensing commitment from Silvia and any other CSSWG members who contributed to the solution design during the dialog.

We could also make a feature request for ash-nazg to track CG members who have signed the CLA and relate the CG to the appropriate WG. In this case from the CLA text it seems that the commitment has already been made but ash-nazg doesn't know about it.

@dwsinger
Copy link

dwsinger commented Jun 27, 2017 via email

@silviapfeiffer
Copy link
Member Author

Relax. This is all a misunderstanding.
I tried to get ash-nazg to green my patch because I was under the impression that I was part of the CG and the WG as a member of both and accidentally got it to mark it as unsubstantial. I later found out that I had been removed as a CG member (not sure about WG, but I'd be happy to join that again also). I have re-joined the CG and all my contributions are covered, as they have been before. I can publicly confirm here that my contibutions fall under the licensing committment.
Hope this helps.

@nigelmegitt
Copy link
Contributor

@silviapfeiffer thanks I thought it might be something like that. If you can join the WG that would be the easiest and cleanest solution from my perspective.

@silviapfeiffer
Copy link
Member Author

Request sent.

@silviapfeiffer silviapfeiffer changed the title Updates to region identifier, CSS selection & existance. Normative: Updates to region identifier, CSS selection & existance. Jul 23, 2017
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Aug 15, 2017
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Aug 15, 2017
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request Aug 28, 2017
rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants