Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Added --binary-arg option, which passes an argument to the browser binary. #177

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

asajeffrey
Copy link

Added a --servo-arg command line option, and a matching servo_args parameter to ServoBrowser. This passes arbitrary command line arguments to Servo.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6303

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@asajeffrey
Copy link
Author

Handles #176, but just for Servo. Ideally there would be a generic solution for every browser, but I can't see how to do this without a breaking change.

@jgraham
Copy link
Member

jgraham commented Mar 27, 2016

Hmm, what's the problem with making a solution that can work for all browsers (even if you don't implement it for all of them)?

@asajeffrey
Copy link
Author

@jgraham depends how we do it. When I wrote that comment, I was thinking about adding an argument to *Brower::init, which is a breaking change. On thinking about it, we could just use the browser_kwargs function in the way that ServoBrowser does.

The only change this would make is for the option name to be --binary_arg rather than --servo-arg, and for it to be listed in the main options rather than the servo-only options (even if it is documented as servo-only).

It's a bit tricky for me to test on other browsers, not sure what we should do about this -- I don't want to break wptrunner for firefox, chrome, etc.

@asajeffrey
Copy link
Author

I pushed a commit which renames --servo-arg to --binary-arg, so other browsers could use the same mechanism. @jgraham: does this seem better to you?

This is only for servo right now, but other browsers could add support.
@asajeffrey asajeffrey changed the title Added --servo_arg option, which passes an argument to the servo binary. Added --binary-arg option, which passes an argument to the browser binary. Mar 31, 2016
@jgraham jgraham merged commit 357411c into w3c:master Mar 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants