Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multifilter fase 1 #31

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Refactor multifilter fase 1 #31

merged 3 commits into from
Sep 24, 2020

Conversation

w3nl
Copy link
Owner

@w3nl w3nl commented Sep 23, 2020

No description provided.

@ghost
Copy link

ghost commented Sep 23, 2020

DeepCode's analysis on #cc3e44 found:

  • ⚠️ 1 warning 👇

Top issues

Description Example fixes
Two subsequent branches of an if statement have duplicate bodies (here and here). This may be caused by a copy-paste error. If this usage is intentional, consider merging the branches to avoid code duplication. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          162       153    -9     
  Branches        33        28    -5     
=========================================
- Hits           162       153    -9     
Impacted Files Coverage Δ
src/modules/multifilter.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf4a87...cc3e44a. Read the comment docs.

@w3nl w3nl force-pushed the feature/refactor-multifilter branch 3 times, most recently from 29947b4 to 92feae1 Compare September 24, 2020 09:21
@w3nl w3nl force-pushed the feature/refactor-multifilter branch from 92feae1 to cc3e44a Compare September 24, 2020 09:32
@w3nl w3nl merged commit f9440ef into master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant